Closed
Bug 1482197
Opened 7 years ago
Closed 7 years ago
MediaCapabilities fail on worker
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
Details
Attachments
(3 files)
There's a silly error in the code:
https://searchfox.org/mozilla-central/rev/0f4d50ff5211e8dd85e119ef683d04b63062ed90/dom/media/mediacapabilities/MediaCapabilities.cpp#410
wrong use of variable name, meaning that the test just after will always fail.
Spotted by :bz
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
It can be called on a worker.
Depends on D3054
Assignee | ||
Comment 3•7 years ago
|
||
Depends on D3055
Comment on attachment 8998977 [details]
Bug 1482197 - P1. Fix variable name in MediaCapabilities. r?bryce
Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #8998977 -
Flags: review+
Comment on attachment 8998980 [details]
Bug 1482197 - P2. Make IsWebMEncoderEnabled usable off the main thread. r?bryce
Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #8998980 -
Flags: review+
Comment on attachment 8998982 [details]
Bug 1482197 - P3. Update wpt expected values. r?bryce
Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #8998982 -
Flags: review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aea50d33724c
P1. Fix variable name in MediaCapabilities. r=bryce
https://hg.mozilla.org/integration/mozilla-inbound/rev/b472c4e49ac6
P2. Make IsWebMEncoderEnabled usable off the main thread. r=bryce
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb3e357f21b4
P3. Update wpt expected values. r=bryce
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/aea50d33724c
https://hg.mozilla.org/mozilla-central/rev/b472c4e49ac6
https://hg.mozilla.org/mozilla-central/rev/bb3e357f21b4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•7 years ago
|
Assignee: nobody → jyavenard
You need to log in
before you can comment on or make changes to this bug.
Description
•