Closed Bug 1482205 Opened Last year Closed Last year

Add top search, fixed search and bug fixes to Activity Stream

Categories

(Firefox :: New Tab Page, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

(Depends on 2 open bugs)

Details

(Whiteboard: [export])

User Story

https://github.com/mozilla/activity-stream/compare/65eacf8eef567356aef588c63c902dc50ccbd224...d610b25ba48293ad5d347cddccdbae1c3adfb6dd

Attachments

(1 file)

No description provided.
User Story: (updated)
Depends on: 1478649, 1481605
Comment on attachment 8998963 [details]
Bug 1482205 - Add top search, fixed search and bug fixes to Activity Stream

Kate Hudson :k88hudson has approved the revision.
Attachment #8998963 - Flags: review+
Comment on attachment 8998963 [details]
Bug 1482205 - Add top search, fixed search and bug fixes to Activity Stream

Kate Hudson :k88hudson has requested changes to the revision.
Attachment #8998963 - Flags: review+
Comment on attachment 8998963 [details]
Bug 1482205 - Add top search, fixed search and bug fixes to Activity Stream

Kate Hudson :k88hudson has approved the revision.
Attachment #8998963 - Flags: review+
User Story: (updated)
Depends on: 1482190
User Story: (updated)
Depends on: 1482247
User Story: (updated)
Depends on: 1482209, 1482255, 1480513
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/972b3c48c6e9
Add top search, fixed search and bug fixes to Activity Stream r=k88hudson
https://hg.mozilla.org/mozilla-central/rev/972b3c48c6e9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
No longer depends on: 1482404
I'm getting RangeError: invalid array length[Learn More] TopSitesFeed.jsm:177:9 which results in my top sites being blank in today's Nightly 20180810100128 on Linux x86_64. It appears this patch is responsible.

      // The plainPinnedSites array is populated with pinned sites at their
      // respective indices, and null everywhere else, but is not always the
      // right length
      const pinnedSites = [...plainPinnedSites].concat(
->      Array(numberOfSlots - plainPinnedSites.length).fill(null)
      );
(In reply to Bob Clary [:bc:] from comment #7)
> I'm getting RangeError: invalid array length[Learn More]
> TopSitesFeed.jsm:177:9 which results in my top sites being blank in today's
> Nightly 20180810100128 on Linux x86_64.
Thanks, fixing in https://github.com/mozilla/activity-stream/pull/4312

For now, you can just increase the number of top site rows from about:preferences#home
Blocks: 1482523
Depends on: 1482612
Depends on: 1482914
No longer blocks: 1486709
Depends on: 1486709
Depends on: 1488072
Depends on: 1479021
Marking this as qe-verify + until all its dependencies are assessed/verified.
Flags: qe-verify+
Whiteboard: [export]
Whiteboard: [export] → [export][qa-triaged]
QA Whiteboard: [qa-triaged]
Whiteboard: [export][qa-triaged] → [export]

Removing the qe-verify flag as most of the dependencies have been verified and this work has already made it in Release.

Flags: qe-verify+
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.