1482205 - Add top search, fixed search and bug fixes to Activity Stream

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1482205 - Add top search, fixed search and bug fixes to Activity Stream

Comment 2

[Kate Hudson :k88hudson]

Comment on attachment 8998963 [details]
Bug 1482205 - Add top search, fixed search and bug fixes to Activity Stream

Kate Hudson :k88hudson has approved the revision.

Comment 3

[Kate Hudson :k88hudson]

Comment on attachment 8998963 [details]
Bug 1482205 - Add top search, fixed search and bug fixes to Activity Stream

Kate Hudson :k88hudson has requested changes to the revision.

Comment 4

[Kate Hudson :k88hudson]

Comment on attachment 8998963 [details]
Bug 1482205 - Add top search, fixed search and bug fixes to Activity Stream

Kate Hudson :k88hudson has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/972b3c48c6e9
Add top search, fixed search and bug fixes to Activity Stream r=k88hudson

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/972b3c48c6e9

Comment 7

[Bob Clary [:bc] (inactive)]

I'm getting RangeError: invalid array length[Learn More] TopSitesFeed.jsm:177:9 which results in my top sites being blank in today's Nightly 20180810100128 on Linux x86_64. It appears this patch is responsible.

      // The plainPinnedSites array is populated with pinned sites at their
      // respective indices, and null everywhere else, but is not always the
      // right length
      const pinnedSites = [...plainPinnedSites].concat(
->      Array(numberOfSlots - plainPinnedSites.length).fill(null)
      );

Comment 8

[Ed Lee :Mardak]

(In reply to Bob Clary [:bc:] from comment #7)
> I'm getting RangeError: invalid array length[Learn More]
> TopSitesFeed.jsm:177:9 which results in my top sites being blank in today's
> Nightly 20180810100128 on Linux x86_64.
Thanks, fixing in https://github.com/mozilla/activity-stream/pull/4312

For now, you can just increase the number of top site rows from about:preferences#home

Comment 9

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

Marking this as qe-verify + until all its dependencies are assessed/verified.

Comment 10

[Ciprian Muresan [:cmuresan], Ecosystem QA; PTO Until the 7th of June, please ping @poiegas]

Removing the qe-verify flag as most of the dependencies have been verified and this work has already made it in Release.