Closed Bug 1482235 Opened Last year Closed Last year

test_PlacesSearchAutocompleteProvider.js should set Services.appinfo.name for xpcshell

Categories

(Toolkit :: Places, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

test_PlacesSearchAutocompleteProvider.js is getting a Javascript strict error when running:

 0:01.19 pid:5928 JavaScript strict warning: file:///Users/michaelkaply/Projects/mozilla-unified/obj-x86_64-apple-darwin16.7.0/dist/Nightly.app/Contents/Resources/components/nsSearchService.js, line 694: ReferenceError: reference to undefined property "name"

This is because xpcshell tests that use search should do:

ChromeUtils.import("resource://testing-common/AppInfo.jsm");
updateAppInfo();

So that have Services.appInfo.name is set.
Comment on attachment 8998983 [details]
Bug 1482235 - Import AppInfo for test.

Ed Lee :Mardak has approved the revision.
Attachment #8998983 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/0d3b8e14e25f
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Blocks: 1482398
Whiteboard: [fxsearch]
You need to log in before you can comment on or make changes to this bug.