1482235 - test_PlacesSearchAutocompleteProvider.js should set Services.appinfo.name for xpcshell

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P5)

Description

[Mike Kaply [:mkaply]]

test_PlacesSearchAutocompleteProvider.js is getting a Javascript strict error when running:

 0:01.19 pid:5928 JavaScript strict warning: file:///Users/michaelkaply/Projects/mozilla-unified/obj-x86_64-apple-darwin16.7.0/dist/Nightly.app/Contents/Resources/components/nsSearchService.js, line 694: ReferenceError: reference to undefined property "name"

This is because xpcshell tests that use search should do:

ChromeUtils.import("resource://testing-common/AppInfo.jsm");
updateAppInfo();

So that have Services.appInfo.name is set.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1482235 - Import AppInfo for test.

Comment 2

[Ed Lee :Mardak]

Comment on attachment 8998983 [details]
Bug 1482235 - Import AppInfo for test.

Ed Lee :Mardak has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d3b8e14e25f
Import AppInfo for test. r=Mardak

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/0d3b8e14e25f

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce79b99f0beb5b75adfbb70bae3a85c7142e978f