1482246 - Failing tests should make taskcluster red

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ed Lee :Mardak]

When trying to export with bug 1482205, there were a bunch of test failures that needed to be fixed. Turns out taskcluster has been reporting green even with test failures.

https://tools.taskcluster.net/groups/Mc08xHIyS8WGyPYTgZYtfA/tasks/Mc08xHIyS8WGyPYTgZYtfA/runs/0/logs/public%2Flogs%2Flive.log#L2977

	Failed: 6

mochitest-browser(B
~~~~~~~~~~~~~~~~~(B
Ran 246 checks (12 tests, 234 subtests)
Expected results: 240
Unexpected results: 6
  subtest: 6 (6 fail)
Unexpected Results(B
------------------(B
browser/components/newtab/test/browser/browser_topsites_contextMenu_options.js(B
  FAIL(B Number of options is correct - 2 == 5 - 
Stack trace:
resource://testing-common/content-task.js line 59 > eval:defaultTopSites_menuOptions:9
  FAIL(B Name option is correct - "Unpin" == "Pin" - 
Stack trace:
resource://testing-common/content-task.js line 59 > eval:defaultTopSites_menuOptions:14
  FAIL(B Name option is correct - "Dismiss" == "Edit" - 
Stack trace:
resource://testing-common/content-task.js line 59 > eval:defaultTopSites_menuOptions:14
  FAIL(B Uncaught exception - TypeError: contextMenuItems[4] is undefined
browser/components/newtab/test/browser/browser_topsites_section.js(B
  FAIL(B Uncaught exception - Topsite should be unpinned - timed out after 50 tries.
  FAIL(B Uncaught exception - No Topsite found - timed out after 50 tries.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4334

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/2a4b437980ba2377f9f017ba09b0f90dff52bc18
Fix Bug 1482246 - Correctly report mochitest failures (#4334)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/13cca9e3e12d