Closed Bug 1482246 Opened Last year Closed Last year

Failing tests should make taskcluster red

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 63
Iteration:
63.4 - Aug 20
Tracking Status
firefox63 --- fixed

People

(Reporter: Mardak, Assigned: andreio)

References

Details

Attachments

(1 file)

When trying to export with bug 1482205, there were a bunch of test failures that needed to be fixed. Turns out taskcluster has been reporting green even with test failures.

https://tools.taskcluster.net/groups/Mc08xHIyS8WGyPYTgZYtfA/tasks/Mc08xHIyS8WGyPYTgZYtfA/runs/0/logs/public%2Flogs%2Flive.log#L2977

	Failed: 6

mochitest-browser(B
~~~~~~~~~~~~~~~~~(B
Ran 246 checks (12 tests, 234 subtests)
Expected results: 240
Unexpected results: 6
  subtest: 6 (6 fail)
Unexpected Results(B
------------------(B
browser/components/newtab/test/browser/browser_topsites_contextMenu_options.js(B
  FAIL(B Number of options is correct - 2 == 5 - 
Stack trace:
resource://testing-common/content-task.js line 59 > eval:defaultTopSites_menuOptions:9
  FAIL(B Name option is correct - "Unpin" == "Pin" - 
Stack trace:
resource://testing-common/content-task.js line 59 > eval:defaultTopSites_menuOptions:14
  FAIL(B Name option is correct - "Dismiss" == "Edit" - 
Stack trace:
resource://testing-common/content-task.js line 59 > eval:defaultTopSites_menuOptions:14
  FAIL(B Uncaught exception - TypeError: contextMenuItems[4] is undefined
browser/components/newtab/test/browser/browser_topsites_section.js(B
  FAIL(B Uncaught exception - Topsite should be unpinned - timed out after 50 tries.
  FAIL(B Uncaught exception - No Topsite found - timed out after 50 tries.
Depends on: 1474372
Assignee: nobody → andrei.br92
Blocks: 1479806
Iteration: --- → 63.4 - Aug 20
Priority: -- → P1
No longer blocks: 1479806
Depends on: 1483003
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Blocks: 1483375
https://hg.mozilla.org/mozilla-central/rev/13cca9e3e12d
Target Milestone: --- → Firefox 63
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.