Closed Bug 1482262 Opened 8 years ago Closed 8 years ago

Ensure that test_chrome_ext_webrequest_host_permissions.html can access the images it uses

Categories

(WebExtensions :: Request Handling, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

file_image_good.png isn't currently packaged, and file_with_images.html uses the wrong paths to the image files.
Component: Add-ons Manager → Request Handling
Product: Toolkit → WebExtensions
Comment on attachment 8999009 [details] [diff] [review] Ensure that test_chrome_ext_webrequest_host_permissions.html can access the images it uses Kris, I'll send this one to you as well since this is about the same test as bug 1482277 and it's a trivial review. I encountered this while debugging this test, but this fix shouldn't have any material effect over what this test is testing...
Attachment #8999009 - Flags: review?(tomica) → review?(kmaglione+bmo)
Attachment #8999009 - Flags: review?(kmaglione+bmo) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/69df43ebd6a3 Ensure that test_chrome_ext_webrequest_host_permissions.html can access the images it uses; r=kmag
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → ehsan
Can you please add some STRs to this issue(and add a test webextension if possible) or mark the bug as "qe-verify-" ?
Is there a process for doing this for every single bug fix that lands?
Flags: qe-verify-
(In reply to :Ehsan Akhgari from comment #6) > Is there a process for doing this for every single bug fix that lands? For Webextensions, we require that all bugs be verified by QA. So, when a bug is marked RESOLVED FIXED, we ask the dev to provide STR to verify the bug to expedite the process or mark the bug as qe-verify- so that QA doesn't have to worry about it. Hope that adds some context to you.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: