1482266 - Check some binary properties *after* strip

Status: NEW

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

By pure chance, I found that stripping lld-linked binaries removes the GNU_RELRO segment, removing the hardening from bug 1359912.

This seems like a bug in binutils, and upgrading binutils should be enough, but since that changes many things, we need to handle this with care. Anyways, this bug is about the fact that we should actually do post-staging checks, because this was only caught by chance (it triggered a behavior flaw in elfhack, that is now fixed).

Comment 1

[(not currently active) Ted Mielczarek]

Would it make sense to just roll this into a separate post-build verification task like I suggested in bug 1482690 for symbols?

Comment 2

[Mike Hommey [:glandium]]

Makes sense.