Closed Bug 1482277 Opened 4 years ago Closed 4 years ago

Rewrite test_chrome_ext_webrequest_host_permissions.html to make it not depend on the order in which HTTP notifications are dispatched

Categories

(WebExtensions :: Request Handling, defect)

defect
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

No description provided.
Blocks: 1478539
Assignee: nobody → ehsan
Comment on attachment 8999034 [details] [diff] [review]
Rewrite test_chrome_ext_webrequest_host_permissions.html to make it not depend on the order in which HTTP notifications are dispatched

Review of attachment 8999034 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

::: toolkit/components/extensions/test/mochitest/test_chrome_ext_webrequest_host_permissions.html
@@ +37,5 @@
>  
>    const win1 = window.open("https://example.com/chrome/toolkit/components/extensions/test/mochitest/file_with_images.html");
> +  let urls = [];
> +  urls.push(await all.awaitMessage("png"));
> +  urls.push(await all.awaitMessage("png"));

Nit: I'd prefer:

    let urls = [await ...,
                await ...];

or something similar.
Attachment #8999034 - Flags: review?(kmaglione+bmo) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea11fbe9e4a6
Rewrite test_chrome_ext_webrequest_host_permissions.html to make it not depend on the order in which HTTP notifications are dispatched; r=kmag
https://hg.mozilla.org/mozilla-central/rev/ea11fbe9e4a6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Can you please add some STRs to this issue(and add a test webextension if possible) or mark the bug as "qe-verify-" ?
Flags: needinfo?(ehsan)
Flags: needinfo?(ehsan) → qe-verify-
You need to log in before you can comment on or make changes to this bug.