Closed Bug 1482294 Opened Last year Closed Last year

disable jit unwind handling on aarch64 windows

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As the comment for SetJitExceptionHandler makes clear, the
infrastructure we have for generating unwind information on 64-bit
Windows is only necessary to permit Breakpad to generate crash reports.
We don't even have crash reporting for our non-existent AArch64 Windows
builds, and it will likely take us some time to make the necessary
changes in Breakpad and elsewhere.  In addition, the unwind information
format is completely different on AArch64, and there's no decent
documentation on it yet.

Given all of this, the easiest way forward right now is to simply
disable this code to get things compiling.  We can reenable it later
once we understand how to add appropriate support.
I don't particularly like doing this, but I'm open to better options.
Attachment #8999042 - Flags: review?(jdemooij)
Comment on attachment 8999042 [details] [diff] [review]
disable jit unwind handling on aarch64 windows

Seems reasonable. Maybe file a follow-up bug blocking the relevant ship-on-windows-aarch64 bug just to make sure we double check this eventually?
Attachment #8999042 - Flags: review?(jdemooij) → review+
Blocks: 1484835
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81466097f47d
disable jit unwind handling on aarch64 windows; r=jandem
https://hg.mozilla.org/mozilla-central/rev/81466097f47d
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.