Closed
Bug 1482354
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 12402 - service worker: Fix navigation-preload/resource-timing.https.html test
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 12402 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12402 Details from upstream follow. Kenichi Ishibashi <bashi@chromium.org> wrote: > service worker: Fix navigation-preload/resource-timing.https.html test > > Before this CL, this test chains Response#text() and Response creation > inside the callback of FetchEvent#preloadResponse. This seems wrong as > preloadResponse can be resolved before reading response body. This CL > moves response creation out of the callback so that we can make sure > that preloadResponse will be always resolved after response body is > consumed, which is required to make the test work. > > Bug: 872078 > Change-Id: I6ecfcb8e0721df541d5a32f56ec4c062efbffdae > > Reviewed-on: https://chromium-review.googlesource.com/1170679 > WPT-Export-Revision: 9e23052520eea87a21622e75c9fed49bab280dce
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe48de275d11449faee7edbc4ee23bae0533b84d
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b192d0bcb88411c4d554b1a1953f8c936642e456
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=246b82ef835b66e7ea2021c7e766126fcfc14d20
Assignee | ||
Comment 4•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cbbb2618c3ddedceb275ec0bb16988efc246726
Assignee | ||
Comment 5•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=37c5eb01454584679ab3bd574f8c8dfb9fa91858
Assignee | ||
Comment 6•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c7601a7d3c0919f9d39dd2281ad2e6c7c0c78ad
Assignee | ||
Comment 7•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad4063bf1f17e7f1366fc8f15495b0fc56300b4f
Assignee | ||
Comment 8•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=46377f0bb03a12787f323f8aed9b574fb3b963ef
Assignee | ||
Comment 9•6 years ago
|
||
Ran 1 tests and 1 subtests OK : 1 FAIL : 1
Comment 10•6 years ago
|
||
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8f26e8ff5c9f [wpt PR 12402] - service worker: Fix navigation-preload/resource-timing.https.html test, a=testonly
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8f26e8ff5c9f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•