Closed Bug 1482354 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12402 - service worker: Fix navigation-preload/resource-timing.https.html test

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12402 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12402
Details from upstream follow.

Kenichi Ishibashi <bashi@chromium.org> wrote:
>  service worker: Fix navigation-preload/resource-timing.https.html test
>  
>  Before this CL, this test chains Response#text() and Response creation
>  inside the callback of FetchEvent#preloadResponse. This seems wrong as
>  preloadResponse can be resolved before reading response body. This CL
>  moves response creation out of the callback so that we can make sure
>  that preloadResponse will be always resolved after response body is
>  consumed, which is required to make the test work.
>  
>  Bug: 872078
>  Change-Id: I6ecfcb8e0721df541d5a32f56ec4c062efbffdae
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1170679
>  WPT-Export-Revision: 9e23052520eea87a21622e75c9fed49bab280dce
Ran 1 tests and 1 subtests
OK     : 1
FAIL   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f26e8ff5c9f
[wpt PR 12402] - service worker: Fix navigation-preload/resource-timing.https.html test, a=testonly
https://hg.mozilla.org/mozilla-central/rev/8f26e8ff5c9f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.