Port bug 1371951 changes to extension-mac.css

RESOLVED FIXED in Firefox 63

Status

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: ntim, Assigned: e7358d9c)

Tracking

unspecified
mozilla63
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
Post-reviewing bug 1371951, I noticed browser/components/extensions/extension-mac.css needs to be updated as well.
(Assignee)

Comment 1

8 months ago
On it.
Assignee: nobody → e7358d9c
Comment on attachment 8999198 [details]
Bug 1482411 - Port bug 1371951 changes to extension-mac.css

Shane Caraveo (:mixedpuppy) has approved the revision.
Attachment #8999198 - Flags: review+

Comment 4

8 months ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/56aaeff290b7
Port bug 1371951 changes to extension-mac.css r=mixedpuppy

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/56aaeff290b7
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63

Comment 6

8 months ago
Can you please add some STRs to this issue(and add a test webextension if possible) or mark the bug as "qe-verify-" ?
(Assignee)

Comment 7

8 months ago
(In reply to Victor Carciu from comment #6)
> Can you please add some STRs to this issue(and add a test webextension if
> possible) or mark the bug as "qe-verify-" ?

(In reply to ExE Boss from bug 1371951 comment #61)
> I don’t think it is, as the style changes are covered using automated tests,
> but you can use attachment 8955426 [details] to do a before and after
> comparison in the options page, which has `<input type="checkbox">`
> and `<input type="radio">` in all the possible configurations.
> 
> Without this patch, only the first one works, but with this patch,
> all of them work correctly (see attachment 8956189 [details]).
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.