1482412 - Incorrect conversion to search topsite

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Andrei Oprea [:andreio]]

Attachment: Screen Shot 2018-08-10 at 16.09.19.png

Two different issues here maybe:
1) See attachament. The site is amazon.de. It shows up as a search topsite but without the `@`.

2) The correct @amazon and @google search topsites have been inserted. Although they point to the .com address even though my browser locale is DE.

Comment 1

[Andrei Oprea [:andreio]]

1) Seems to be just a "visual" glitch. This is the topsite in my pinned pref {"url":"https://www.amazon.de/","label":"amazon","customScreenshotURL":"..."} Somehow it gets shown as a search topsite even though the pinned label for search is not there.

Comment 2

[Andrei Oprea [:andreio]]

2) Seems also only a visual issue. It actually uses the local version of the search engine.

Comment 3

[Ed Lee :Mardak]

The <a> does get set to the url that is shown in the status bar, so regular link actions, e.g., right-click act on the url. We probably don't want that. Not sure if we should just get rid of the url somehow unless we get the correct url from the search engine.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4313

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/df3f4f3b13aa0df04d28297f264cf8223754b71b
Merge pull request #4313 from piatra/bug1482412

Fix Bug 1482412 - Don't change the status of existing pinned sites

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/322c3cf43fe8

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 8

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible in the latest Nightly (63.0a1, Build ID 20180815225731) on Windows 10, Mac 10.13 and Linux x64 with the "browser.search.region" pref set to "DE". A previously pinned Amazon Top Site will no longer be converted to a search Top Site.

Comment 9

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is not reproducible in the latest Firefox Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Linux x64 with the "browser.search.region" pref set to "DE". A previously pinned Amazon Top Site is not converted to a search Top Site.