Closed Bug 1482432 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 12412 - [LayoutNG] Flip for writing mode when calculating inline bounding box.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12412 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12412
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  [LayoutNG] Flip for writing mode when calculating inline bounding box.
>  
>  LayoutInline::LinesVisualOverflowBoundingBox() is expected to return
>  coordinates with a logical block coordinate. So we need to flip for
>  writing-mode vertical-rl.
>  
>  Discovered while investigating why
>  wpt/css/css-position/position-sticky-writing-modes.html fails. It had
>  some weird repaint issues (that I discovered when picking the test
>  apart) that this CL fixes. That's not enough to fix the test, though.
>  
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  Change-Id: I9a8930cc6de01991592282491677327e3406acfb
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1170835
>  WPT-Export-Revision: ebcd3d741b6ecf3991bf79ca58649dd10d9acdf1
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
FAIL   : 1

New tests that have failures or other problems:
/css/css-writing-modes/relpos-inline-overflowing-block-vrl.html: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa25989fd91d
[wpt PR 12412] - [LayoutNG] Flip for writing mode when calculating inline bounding box., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9960e439b12
[wpt PR 12412] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/aa25989fd91d
https://hg.mozilla.org/mozilla-central/rev/b9960e439b12
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.