Closed Bug 1482439 Opened Last year Closed Last year

Add titlebar toggle in customize menu

Categories

(Thunderbird :: Toolbars and Tabs, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 63.0

People

(Reporter: ryan, Assigned: Paenglab)

Details

Attachments

(2 files, 3 obsolete files)

Right now on Windows the default ships without a title bar. Toggling it appears to require going into the config editor.

Should probably live in both customize and as a toggle next to the checkboxes for menu bar and the like.
What do you think?
Flags: needinfo?(richard.marti)
In customize dialog would be okay but not in menu because this is nothing that will be changed frequently.
Flags: needinfo?(richard.marti)
Just sent you an Email about this. Is it easy enough to implement? This option exists in Customize in FF.
Attached patch titlebarToggle.patch (obsolete) — Splinter Review
This adds a checkbox in customize dialog. FX uses a simple "Title Bar" as string. I extended it to "Show Title Bar" to be more clear, okay?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8999336 - Flags: review?(mkmelin+mozilla)
[started using ff without title bar on ubuntu just now, and I'm liking it]

There's some glitch with the patch. Once I uncheck the "Show Title Bar" the customization bar is gone, and I can't get back to Customize - so no way to get the setting saved.
(In reply to Magnus Melin from comment #5)
> [started using ff without title bar on ubuntu just now, and I'm liking it]

Me too, also with TB.

> There's some glitch with the patch. Once I uncheck the "Show Title Bar" the
> customization bar is gone, and I can't get back to Customize - so no way to
> get the setting saved.

It's still there but behind the main window. This seems to be a Linux specialty that the customize window looses the state to be on top when the main window makes a refresh. On Mac and Windows is this no problem. On Mac it is only that, when the titlebar is fading in, everything is shifting down and the customize window hidesa part of the toolbar because it stays and isn't movable.

I needed also to change the checkbox ID because on Mac exists a rule to hide the #toolbar. I can upload the new patch with only the ID change but no other change if you like. But I think before we need to know how to go further.
Yeah I notice now it's there behind the window. That's very confusing... I have to say I the experience on Firefox is also not very pleasing (although working). The instant apply for this setting makes the window jump around a little. 

Anyway, we need to find some way for the customization to stay on top, or get back to top (even if just with a timeout or something)
Attached patch titlebarToggle.patch (obsolete) — Splinter Review
Adding my last patch and removing the r? until we have a solution for the customize window to stay on top which I need help.
Attachment #8999336 - Attachment is obsolete: true
Attachment #8999336 - Flags: review?(mkmelin+mozilla)
Just focusing back on a timeout helps. Not very elegant though.

I guess ideally we should move customization to a tab instead.

BTW, it doesn't seem the patch works for compose (and other non-3pane windows)
(In reply to Magnus Melin from comment #9)
> Created attachment 9001566 [details] [diff] [review]
> titlebarToggle.patch (with focus on a timeout)
> 
> Just focusing back on a timeout helps. Not very elegant though.

Thanks.

> I guess ideally we should move customization to a tab instead.

In AB, composer or the Event window there is no possibility to open in a tab is it? Also do we have Chat- or Lightning tabs. Then the code needs to check which tab needs to ne customized.

> BTW, it doesn't seem the patch works for compose (and other non-3pane
> windows)

Correct. Is there a possibility to check from which window the customize dialog is opened? Then the checkbox could be hidden and only shown on 3pane.
You should be able to check who opened window.opener
I meant using window.opener.
Patch with focus on a timeout and check for 3pane window.
Attachment #8999393 - Attachment is obsolete: true
Attachment #9001566 - Attachment is obsolete: true
Attachment #9001660 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9001660 [details] [diff] [review]
titlebarToggle.patch

Review of attachment 9001660 [details] [diff] [review]:
-----------------------------------------------------------------

Looks alright to me. r=mkmelin
Attachment #9001660 - Flags: review?(mkmelin+mozilla) → review+
Thanks.
Keywords: checkin-needed
Comment on attachment 9001660 [details] [diff] [review]
titlebarToggle.patch

Review of attachment 9001660 [details] [diff] [review]:
-----------------------------------------------------------------

::: common/src/customizeToolbar.js
@@ +546,5 @@
> +  let titlebarCheckbox = document.getElementById("showTitlebar");
> +  Services.prefs.setBoolPref("mail.tabs.drawInTitlebar", !titlebarCheckbox.checked);
> +
> +  // Bring the customizeToolbar window to front (on linux it's behind the main
> +  // window). Otherwise the customization window get's left in the background.

What exactly is "get's"?
(In reply to Jorg K (GMT+2) from comment #16)
> What exactly is "get's"?

Could you use "stays in the background."?
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e96c399d6133
Add a titlebar checkbox in customize dialog. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
Is there a specific reason that the new entity is called showTitltbar.label instead of showTitlebar.label or is this a tpyo?
It's a typo.
Attachment #9005910 - Flags: review?(jorgk)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b79e5c816ecb
Follow-up: fix spelling of showTitlebar.label. r=me DONTBUILD
Comment on attachment 9005910 [details] [diff] [review]
Bug1482439-typo.patch

I was faster ;-)
Attachment #9005910 - Flags: review?(jorgk) → review+
You need to log in before you can comment on or make changes to this bug.