Closed Bug 1482593 Opened 7 years ago Closed 3 years ago

Support launching mach via py.exe on Windows

Categories

(Firefox Build System :: Mach Core, enhancement)

All
Windows
enhancement

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: e7358d9c, Unassigned)

References

Details

Attachments

(1 obsolete file)

Bug 957721 changed the shebang line from `#!/usr/bin/env python` to `#!/usr/bin/env python2.7` and then to: ```python #!/bin/sh '''which' python2.7 > /dev/null && exec python2.7 "$0" "$@" || exec python "$0" "$@" ''' ``` The last one broke compatibility with `py.exe` (https://www.python.org/dev/peps/pep-0394/) making it impossible to run mach directly on Windows. If the shebang line is instead set to `#!/usr/bin/env python2.7` or `#!/usr/bin/env python2`, then it works (mostly) fine with `py.exe`, but the code page has to be changed from 65001 (UTF‑8) to 1252 (Windows-1252), as Python 2 doesn’t know that Windows maps cp65001 to UTF‑8, but Python 3 does. There’s also the `win_unicode_console` Python package¹, which adds proper Unicode support to Python on Windows. ¹ https://pypi.org/project/win_unicode_console/ --- Relevant Python issues: - https://bugs.python.org/issue13216 - https://bugs.python.org/issue1602 (esp. https://bugs.python.org/issue1602#msg145898)
Assignee: nobody → e7358d9c
Status: NEW → ASSIGNED

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: e7358d9c → nobody
Status: ASSIGNED → NEW
Severity: normal → S3

The following patch is waiting for review from reviewers who are inactive or resigned from the review:

ID Title Author Reviewer Status
D3141 Bug 1482593 - Support launching mach via py.exe on Windows e7358d9c glandium: Resigned from review
mshal: Resigned from review
gps: Resigned from review

:e7358d9c, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit auto_nag documentation.

Flags: needinfo?(e7358d9c)

We no longer support building with python2, and use a standard shebang as documented in https://docs.python.org/3/using/windows.html#shebang-lines so I don't think this apply anymore.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
Flags: needinfo?(e7358d9c)
Attachment #8999325 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: