1482627 - TEST-UNEXPECTED-FAIL | toolkit/modules/tests/xpcshell/test_NewTabUtils.js

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | toolkit/modules/tests/xpcshell/test_NewTabUtils.js | getTopFrecentSites_improveSearch - [getTopFrecentSites_improveSearch : 693] the amazon site was converted to generic search shortcut site - "https://www.amazon.com/?search=tv" == "https://amazon.com"

This is from bug 1480888:
https://hg.mozilla.org/mozilla-central/rev/e623335f541313cd59ced846c6cecaeaca7f2c85#l5.12

Ursula and Kate, this test now fails in the Thunderbird environment. What needs to be done to make it pass, or should it just be disabled?

I see there is a new pref: "browser.newtabpage.activity-stream.improvesearch.topSiteSearchShortcuts". This however appears to be a toolkit test which how has been mixed with browser content.

BTW, you might want to fix the spelling mistake in the function name: getTopFrecentSites

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1482627-xpcshell.txt

Here's a log file. I don't see anything interesting, also no errors related to missing prefs.

Comment 2

[Jorg K (CEST = GMT+2)]

(In reply to Jorg K (GMT+2) from comment #0)
> BTW, you might want to fix the spelling mistake in the function name:
> getTopFrecentSites
Oops, that's a new word creation - https://en.wikipedia.org/wiki/Frecency, sorry.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1482627-disable-test-for-thunderbird.patch

In case we need to switch off the test, here's a patch that does it.

I added two reviewers to expedite this since sheriffing the Thunderbird tree with permanent failures like this one is more time-consuming than it should be.

Comment 4

[Ursula Sarracini (:ursula)]

Comment on attachment 8999535 [details] [diff] [review]
1482627-disable-test-for-thunderbird.patch

Hey Jorg, thanks for doing this patch. Turning it off for thunderbird environment seems fine. We are planning on moving NewTabUtils.jsm out of toolkit and into browser/components/newtab, but until then, skipping this test is probably the way to go.

Comment 5

[Jorg K (CEST = GMT+2)]

Thanks. I have to move this to product "Firefox", so the sheriffs see it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4615903e51b8
Switch off test_NewTabUtils.js::getTopFrecentSites_improveSearch for Thunderbird. r=ursula

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/4615903e51b8