1482633 - Unexpected default pinned top search for various locale and region combinations

Status: RESOLVED INVALID

(Firefox :: New Tab Page, enhancement, P2)

Description

[Ed Lee :Mardak]

Google and amazon get pinned but might need to be baidu and google ??

Maria, is there a document with the appropriate default pins?

https://download.mozilla.org/?product=firefox-nightly-latest-l10n-ssl&os=osx&lang=zh-CN

Array(6) [ "google", "bing", "baidu", "wikipedia-zh-CN", "amazondotcn", "ddg" ]

Also, @amazon doesn't actually work (as we don't want it for amazondotcn), but that's a separate bug 1482629.

Comment 1

[Ed Lee :Mardak]

Attachment: no baidu default pinned

Comment 2

[Ed Lee :Mardak]

mkaply, I would guess this is because we do default pins based on geo/region. Because I'm testing zh-CN from US, it decides to pin google and amazon. What should the expected behavior be for zh-CN for various regions?

Here's what I see right now:

zh-CN/CN: google default search, baidu pinned top search
zh-CN/CA: google default search, google pinned top search
zh-CN/US: google default search, google and amazon pinned top search

Comment 4

[Ed Lee :Mardak]

From the other bug for ru / yandex:

attachment 8999356 [details] showing ru locale, US region

Google is pinned but not yandex. The default search engine shows up as google and is pinned.

Array(7) [ "google", "wikipedia-ru", "mailru", "yandex-ru", "ddg", "ozonru", "priceru" ]

Comment 5

[Mike Kaply [:mkaply]]

What you see is exactly what I would expect. Default pins depend on region

Comment 6

[Ed Lee :Mardak]

So amazon should be pinned based on the desired region even though it's a different amazon? In this case it's amazon.cn for zh-CN/US, and a de/US user should have amazon.de pinned? Or those are different because amazondotcn does not have an alias but amazondotcom-de does get an alias? Or does a US region need to somehow use amazon.com?

Comment 7

[Mike Kaply [:mkaply]]

> Or those are different because amazondotcn does not have an alias but amazondotcom-de does get an alias?

That's correct.

We should only pin things that have an internal alias. That's why I was explicit as to which amazons get mapped.

Right now we don't do region mapping of amazon like we do for eBay. It's on the todo list.

Comment 8

[Ed Lee :Mardak]

Okay, sounds like the defaults by region and nothing related to locale is expected. The amazon getting pinned or showing up as an organic top search is bug 1482629.