Closed
Bug 1482637
Opened 6 years ago
Closed 6 years ago
Missing trailing period in string for lack of blockable content (contentBlocking.notDetected)
Categories
(Firefox :: Site Identity, enhancement, P1)
Firefox
Site Identity
Tracking
()
VERIFIED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | verified |
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(2 files)
Copy and past from bug 1476218 Sorry, only noticed this when I started translating https://hg.mozilla.org/mozilla-central/rev/e55d75be1dcd#l8.16 +<!ENTITY contentBlocking.detected "Blockable content detected on this site."> +<!ENTITY contentBlocking.notDetected "No blockable content detected on this page"> The second string is missing a trailing period. If we can fix this quickly, I can wait a few days to expose these strings to tools and let you update the string without a new ID.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → francesco.lodolo
Assignee | ||
Comment 2•6 years ago
|
||
Image from https://mozilla.invisionapp.com/share/VSMVD99JK6D#/screens/301705296
Updated•6 years ago
|
Priority: -- → P1
Comment 3•6 years ago
|
||
Comment on attachment 8999363 [details] Bug 1482637 - Add missing trailing period to contentBlocking.notDetected string Johann Hofmann [:johannh] has approved the revision.
Attachment #8999363 -
Flags: review+
Pushed by francesco.lodolo@mozillaitalia.org: https://hg.mozilla.org/integration/autoland/rev/e915ed47a2af Add missing trailing period to contentBlocking.notDetected string r=johannh
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e915ed47a2af
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•6 years ago
|
Flags: qe-verify+
QA Contact: cristian.comorasu
Comment 6•6 years ago
|
||
I reproduced this issue using Fx 63.0a1 (2018-08-11) on Windows 10 x64. I can confirm this issue is fixed, I verified using Fx 63.0b10 on Windows 10 x64, Ubuntu 14.04 and macOS 10.13.
You need to log in
before you can comment on or make changes to this bug.
Description
•