1482811 - :screenshot - autocomplete issues

Status: NEW

(DevTools :: Console, defect, P3)

Description

[Cristian Fogel [:cfogel]]

[Affected versions]:
- 62.0b16, 63.0a1 (2018-08-12)

[Affected platforms]:
- all

[Steps to reproduce]:
1. Launch Firefox;
2. Open devTools - console tab;
3. type in the console: :screenshot --filename AnyFileName
 
[Expected result]:
- no issues occur;

[Actual results]:
- for :screenshot alone the autocomplete option is not working on beta;
- when inputting the name, past [:screenshot --filename] the options are shown as autocomplete suggestions;

[Regression range]:
- not a regression

[Additional notes]:
- for more info please check
 https://bugzilla.mozilla.org/show_bug.cgi?id=1464461#c145

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Hello Aaditya, would you be interested working on this bug? it should be a bit more challenging than the previous bugs you worked on :)

Comment 4

[Aaditya Arora]

Hi Nicolas,

Yaa... I would like to work on this bug.
BTW thanks for giving me this bug :)

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Hello Aaditya, is there anything blocking you for this bug? Do you still plan to work on it?

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

clearing assignee

Comment 7

[aarushivij]

Hello,
Does this bug sustains presently?
Since I was trying to reproduce it, but I think I did not understand completely.
On typing : autocomplete shows help or screenshot option. Was this the issue?

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Hello aarushivij.
We now do complete the command itself (so typing :s will show the completion text), but it would be nice to complete the parameters of the command too.
So typing :screenshot -- should show filename (the complete list is available in https://developer.mozilla.org/en-US/docs/Tools/Taking_screenshots#Taking_screenshots_with_the_web_console and in the code https://searchfox.org/mozilla-central/rev/2e355fa82aaa87e8424a9927c8136be184eeb6c7/devtools/shared/screenshot/save.js#20-63 )

Comment 9

[aarushivij]

Oh okay
Can I give this a try?
To be honest I am new to Web Development itself , but I think I shall learn by doing things and applying the syntax I have learned till now.
So want to work on it and learn something new.
This may take time though.
:)
So can you please assign to me?
Aarushi

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

this is not a simple task, so I think we should start with something a bit easier :)

Comment 11

[aarushivij]

Okay Thank you :)

Comment 12

[tusharxdev]

Hello @nchevobbe.
I was thinking to work on this bug. I don't think autocompletion for command flags will be required just by this command will it : ) ? Better if I write code which is future proof than just for this specific case. I can only see 2 valid commands which exist as of now which are help and screenshot with the latter being the only one having command flags (https://searchfox.org/mozilla-central/source/devtools/server/actors/webconsole/commands.js#7). Please tell if my information is right or wrong.

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

(In reply to tusharxdev from comment #12)

Hello @nchevobbe.
I was thinking to work on this bug. I don't think autocompletion for command flags will be required just by this command will it : ) ? Better if I write code which is future proof than just for this specific case. I can only see 2 valid commands which exist as of now which are help and screenshot with the latter being the only one having command flags (https://searchfox.org/mozilla-central/source/devtools/server/actors/webconsole/commands.js#7). Please tell if my information is right or wrong.

Hello tushar,

Yes ideally we'd have a generic system to allow autocomplete on commands options.
For now only :screenshot can have options, but I think :help could also have some in the future, or we might have other commands that would have options.

Do you want me to assign the bug to you?

Comment 14

[tusharxdev]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #13)

(In reply to tusharxdev from comment #12)

Hello @nchevobbe.
I was thinking to work on this bug. I don't think autocompletion for command flags will be required just by this command will it : ) ? Better if I write code which is future proof than just for this specific case. I can only see 2 valid commands which exist as of now which are help and screenshot with the latter being the only one having command flags (https://searchfox.org/mozilla-central/source/devtools/server/actors/webconsole/commands.js#7). Please tell if my information is right or wrong.

Hello tushar,

Yes ideally we'd have a generic system to allow autocomplete on commands options.
For now only :screenshot can have options, but I think :help could also have some in the future, or we might have other commands that would have options.

Do you want me to assign the bug to you?

Yes

Comment 15

[Nicolas Chevobbe [:nchevobbe]]

great, it's now yours :)

Comment 16

[tusharxdev]

Attachment: Bug 1482811 - Refactor console commands parser. r=nchevobbe.

Depends on D64417

Comment 17

[tusharxdev]

Attachment: Bug 1482811 - screenshot flags autocomplete issues. r=nchevobbe

Comment 18

[Nicolas Chevobbe [:nchevobbe]]

Hello tushar!
Do you still want to work on this bug? Do you need help?

If you don't/can't work on this, that's totally fine, I'll try to push it through the finish line.

Comment 19

[tusharxdev]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #18)

Hello tushar!
Do you still want to work on this bug? Do you need help?

If you don't/can't work on this, that's totally fine, I'll try to push it through the finish line.

Hello @nchevobbe
We talked about some issues related to this bug on slack and you still haven't replied there. I am still available to work on this problem.

Comment 20

[tusharxdev]

Attachment: Bug 1482811 - New console command parser. r=nchevobbe.

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:nchevobbe, could you have a look please?
For more information, please visit auto_nag documentation.