1482853 - Bing @search Top Sites does not have the same background in Dark theme as in White/Default

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: IMG_13082018_145531_0.png

[Affected versions]:
- Nightly v63.0a1, Build ID 20180812220618

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have the browser's Dark theme enabled.

[Steps to reproduce]:
1. Open the browser with a clean new profile.
2. Click the "..." Top Sites section button.
3. Observe the @searches Top Sites.

[Expected results]:
- All the @search Top Sites look the same as in Light/Default theme.

[Actual results]:
- The @bing Top Site is the only one that has a dark background.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4328

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/b5f4dc5a93c2fbe3f34f29224cf04232d7d9de93
Fix Bug 1482853 - white background for all searchys

https://github.com/mozilla/activity-stream/commit/7a5c5de57a0c8d48d4cee86c463e30842eb3ed6b
Merge pull request #4328 from rlr/bug1482853/bing

Fix Bug 1482853 - white background for all searchys

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4330

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/fcf8f41c1ae2

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 6

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible in the latest Nightly (63.0a1, Build ID 20180815225731) on Windows 10, Mac 10.13 and Linux x64. The Bing search Top Site now has a white background when the browser's dark theme is enabled.

Comment 7

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2018-08-12) on Windows 10 x64.
I retested everything using beta 62.0b19 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12. The bug is not reproducing anymore.