1482854 - Middle clicking an @search Top Site wrongly triggers autoscroll

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: autoscroll conflict.gif

[Affected versions]:
- Nightly v63.0a1, Build ID 20180812220618

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Steps to reproduce]:
1. Open the browser with a clean new profile.
2. Middle click a @search Top Site.
3. Observe the behavior.

[Expected results]:
- The @search term is autocompleted in the Address bar.

[Actual results]:
- The @search term is autocompleted in the Address bar but the autoscroll function is also triggered.

[Notes]:
- The escape key will no longer dismiss the contents of the Address bar after this.
- The issue is reproducible on Linux only with "general.autoScroll" set to true.
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4332

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/03d098de1d3ee85669f4a311c66ed2e54cb86255
Fix Bug 1482854 - Middle clicking an @search Top Site wrongly triggers autoscroll

https://github.com/mozilla/activity-stream/commit/93c6b1d00ebab91fcd633ccda8b2ed7adf00072f
Merge pull request #4332 from sarracini/bug_1482854

Fix Bug 1482854 - Middle clicking an @search Top Site wrongly triggers autoscroll

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/fcf8f41c1ae2

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible in the latest Nightly (63.0a1, Build ID 20180816100035) on Windows 10, Mac 10.13 and Linux x64. Middle clicking a search Top Site no longer triggers the page to autoscroll.

Comment 6

[Cristian Fogel [:cfogel]]

Fix verified on macOS 10.13, Ubuntu 116.04LTS, Windows 10x64 for Firefox 62.0b18.