Closed Bug 1482882 Opened 4 years ago Closed 4 years ago

Remove redundant definition of copyExtraFilesToProfile in remotereftest.py

Categories

(Testing :: Reftest, enhancement)

enhancement
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bc, Assigned: bc)

Details

Attachments

(1 file)

RemoteReftest:createReftestProfile calls Reftest:createReftestProfile which already calls Reftest:copyExtraFilesToProfile which copies the files into the host's profile directory before it is pushed to the device. The RemoteReftest:copyExtraFilesToProfile is not only redundant, it pushes to the device before the profile is actually created which results in

 chmod -R 777 /sdcard/tests/reftest/profile: Ignoring Error: args: adb -s emulator-5554 wait-for-device shell chmod -R 777 /sdcard/tests/reftest/profile; echo rc=$?, exitcode: 10, stdout: Unable to chmod /sdcard/tests/reftest/profile: No such file or directory

We can just remove it from RemoteReftest and allow Reftest to handle it.
try run coming up though my local tests seemed ok.
Attachment #8999609 - Flags: review?(gbrown)
Attachment #8999609 - Flags: review?(gbrown) → review+
Pushed by bclary@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65682bbb4b81
Remove redundant definition of copyExtraFilesToProfile in remotereftest.py, r=gbrown.
https://hg.mozilla.org/mozilla-central/rev/65682bbb4b81
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.