1482882 - Remove redundant definition of copyExtraFilesToProfile in remotereftest.py

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement)

Description

[Bob Clary [:bc] (inactive)]

RemoteReftest:createReftestProfile calls Reftest:createReftestProfile which already calls Reftest:copyExtraFilesToProfile which copies the files into the host's profile directory before it is pushed to the device. The RemoteReftest:copyExtraFilesToProfile is not only redundant, it pushes to the device before the profile is actually created which results in

 chmod -R 777 /sdcard/tests/reftest/profile: Ignoring Error: args: adb -s emulator-5554 wait-for-device shell chmod -R 777 /sdcard/tests/reftest/profile; echo rc=$?, exitcode: 10, stdout: Unable to chmod /sdcard/tests/reftest/profile: No such file or directory

We can just remove it from RemoteReftest and allow Reftest to handle it.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: remotereftests-copyExtra.patch

try run coming up though my local tests seemed ok.

Comment 2

[Bob Clary [:bc] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&filter-tier=1&filter-tier=2&filter-tier=3&group_state=expanded

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65682bbb4b81
Remove redundant definition of copyExtraFilesToProfile in remotereftest.py, r=gbrown.

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/65682bbb4b81