Closed Bug 1482891 Opened 6 years ago Closed 6 years ago

Tab bar/Title bar upper padding differs between account labels and folders

Categories

(Thunderbird :: Mail Window Front End, defect)

x86_64
Windows 10
defect
Not set
minor

Tracking

(thunderbird_esr6062+ fixed, thunderbird62 wontfix, thunderbird63 fixed)

RESOLVED FIXED
Thunderbird 63.0
Tracking Status
thunderbird_esr60 62+ fixed
thunderbird62 --- wontfix
thunderbird63 --- fixed

People

(Reporter: rjhansen075, Assigned: Paenglab)

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180807170231

Steps to reproduce:

Maximize window

Click on a heading in the folderpane, such as "Local Folders" or any "[Account_heading]"

Click on any inbox/folder that has a thread pane. Such as "Inbox" or "Drafts"

Compare.


Actual results:

When switching folderpane contexts in a maximized window, the entire tab bar rises 1 or 2 pixels when clicking on an account heading, and lowers the same when clicking on a folder heading.

The extra pixels in the larger padding appear to be a small amount of title bar above the tabs, which conforms with the behavior when it is a normal window. When an account heading is clicked, the top of the tab completely aligns with the top of the screen, there is no title bar padding above it.


Expected results:

Tab bar/Title bar should remain identical in both contexts. It does remain the same if the window is not maximized.
Severity: normal → minor
OS: Unspecified → Windows 10
Hardware: Unspecified → x86_64
Note: In Firefox 61.0.2, there is never titlebar padding above the tabs. The tab always abuts the top of the window or the screen.
Oh man, my eyes are a little shot, should've put on my reading glasses...

The same behavior appears in a regular, non-maximized window. There is no need to maximize to replicate the bug.

I think, in accordance with Firefox practice, the tabs should never have titlebar padding above them, so it should always behave like it does with account headings. The folder selection changes the titlebar.
Summary: Tab bar/Title bar upper padding differs between account labels and folders when maximized window → Tab bar/Title bar upper padding differs between account labels and folders
Attachment #8999619 - Attachment description: Title bar, maximized window, account heading selected → Title bar, account heading selected
Attachment #8999621 - Attachment description: Title bar, maximized window, folder selected → Title bar, folder selected
Component: Untriaged → Mail Window Front End
I don't see this on Win 10.

Have you tried in safe mode?
Okay. Doesn't happen in safe mode. I'll have to see what's affecting it. It's just my install.
Right. I did a bunch of testing.

The problem is the result of putting the "Mail Views" widget into the title bar.

I don't know if that's something that needs to be fixed or not, but if I take "Mail Views" out of the title bar, it resolves the issue.
Just discovered a problem with spacers being addable but unremovable in the title/tab bar while getting rid of the customizations there to address the problem. I could remove "Mail Views" without issue, which fixes the behavior, but the spacers I had placed between it and the lightning icons are unremovable. Any spacer, in fact. This time I checked "safe mode." The issue persists.

Filed bug 1482939 for that issue.
This is Windows only because on Linux and Mac the menulists are smaller and don't make the tabbar.toolbar taller than the tabbar.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8999697 - Flags: review?(jorgk)
Attachment #8999697 - Flags: approval-comm-esr60?
Attachment #8999697 - Flags: approval-comm-beta?
Comment on attachment 8999697 [details] [diff] [review]
menulistMargin.patch

Yes, this fixes the jumping when the "Mail View" widget it placed into the tab bar (not the most usual configuration).
Attachment #8999697 - Flags: review?(jorgk)
Attachment #8999697 - Flags: review+
Attachment #8999697 - Flags: approval-comm-esr60?
Attachment #8999697 - Flags: approval-comm-esr60+
Attachment #8999697 - Flags: approval-comm-beta?
Attachment #8999697 - Flags: approval-comm-beta+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d9464c86a617
Reduce the top-/bottom-margin for menulists in the tabbar-toolbar too. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
Attachment #8999697 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: