1482955 - Update deprecated terraform configs

Status: RESOLVED FIXED

(MozReview Graveyard :: Infrastructure, enhancement)

Description

[Jake Watkins [:dividehex]]

There is a couple warns being generated from out mozreview-infra/base configs.  We should fix these before they fully break on future terraform releases and they should be quick and simple fixes.


Deprecation warning: This environment is configured to use legacy remote state.
Remote state changed significantly in Terraform 0.9. Please update your remote
state configuration to use the new 'backend' settings. For now, Terraform
will continue to use your existing settings. Legacy remote state support
will be removed in Terraform 0.11.

You can find a guide for upgrading here:

https://www.terraform.io/docs/backends/legacy-0-8.html

Warning: aws_iam_instance_profile.ec2_manage_eip-profile: "roles": [DEPRECATED] Use `role` instead. Only a single role can be passed to an IAM Instance Profile

Warning: aws_iam_instance_profile.ec2_read_keys-profile: "roles": [DEPRECATED] Use `role` instead. Only a single role can be passed to an IAM Instance Profile

Warning: module.cloudtrail.template_file.logging_bucket_policy: using template_file as a resource is deprecated; consider using the data source instead

Comment 1

[Gregory Szorc [:gps]]

MozReview is being nuked at the end of the month.

Depending on which Terraform repo this is, the problem may go away when we delete the Terraform bits in a few weeks...

Comment 2

[Jake Watkins [:dividehex]]

(In reply to Gregory Szorc [:gps] from comment #1)
> MozReview is being nuked at the end of the month.
> 
> Depending on which Terraform repo this is, the problem may go away when we
> delete the Terraform bits in a few weeks...

This terraform repo still manages autoland transplant aws infra and AFAIK that isn't going away just yet.

Comment 3

[Jake Watkins [:dividehex]]

Attachment: GitHub Pull Request - cleanup terraform

Comment 4

[Jake Watkins [:dividehex]]

Attachment: GitHub Pull Request - source cloudtrail moduled from github

Comment 5

[Jake Watkins [:dividehex]]

Terraform comes back clean with no errors or warnings.  r/f