1482956 - Don't dispatch a FinishedAsyncPaintTask message in PaintThread

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

It's not clear that this is needed, and it seems like an unnecessary context switch when using a worker thread pool.

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1482956 - Standardize method names and add comments to PaintThread. r?nical

These method names and ordering have gotten out of sync because of
the recent churn.

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1482956 - Remove templates for FinishedAsyncPaint methods in CompositorBridgeChild. r?nical

This was needed when there were multiple types of CapturedPaintStates but
is not anymore.

Comment 3

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1482956 - Use an AutoTArray in PaintTask to reduce heap allocations. r?nical

There should only ever be at most four TextureClients here, so
allocated a vector seems wasteful.

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1482956 - Don't dispatch extra runnable for ending layer transaction. r?nical

This may have been needed at some point, but all the important code for
EndLayerTransaction is in CompositorBridgeChild behind a lock, so this
should be safe.

Comment 5

[Ryan Hunt [:rhunt] (on leave until early May)]

Wow I really botched that review request. Apologies, first time doing a commit series with phabricator.

Comment 6

[Nicolas Silva [:nical]]

Comment on attachment 8999823 [details]
Bug 1482956 - Don't dispatch extra runnable for ending layer transaction. r?nical

Nicolas Silva [:nical] has approved the revision.

Comment 7

[Nicolas Silva [:nical]]

Comment on attachment 8999821 [details]
Bug 1482956 - Remove templates for FinishedAsyncPaint methods in CompositorBridgeChild. r?nical

Nicolas Silva [:nical] has approved the revision.

Comment 8

[Nicolas Silva [:nical]]

Comment on attachment 8999822 [details]
Bug 1482956 - Use an AutoTArray in PaintTask to reduce heap allocations. r?nical

Nicolas Silva [:nical] has approved the revision.

Comment 9

[Nicolas Silva [:nical]]

Comment on attachment 8999819 [details]
Bug 1482956 - Standardize method names and add comments to PaintThread. r?nical

Nicolas Silva [:nical] has approved the revision.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2300b4b766ca
Remove templates for FinishedAsyncPaint methods in CompositorBridgeChild. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/0448f2851603
Use an AutoTArray in PaintTask to reduce heap allocations. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/2698e4d327ef
Don't dispatch extra runnable for ending layer transaction. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/1185bd909214
Standardize method names and add comments to PaintThread. r=nical

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2300b4b766ca
https://hg.mozilla.org/mozilla-central/rev/0448f2851603
https://hg.mozilla.org/mozilla-central/rev/2698e4d327ef
https://hg.mozilla.org/mozilla-central/rev/1185bd909214

Comment 12

[Ionuț Goldan [:igoldan]]

Noticed some performance gains:

== Change summary for alert #15153 (as of Mon, 20 Aug 2018 06:00:28 GMT) ==

Improvements:

  3%  rasterflood_svg linux64 pgo e10s stylo     12,649.38 -> 12,236.10
  3%  rasterflood_svg linux64 opt e10s stylo     12,014.92 -> 11,639.16
  1%  rasterflood_svg windows10-64 pgo e10s stylo10,263.42 -> 10,166.38
  1%  rasterflood_svg windows10-64 opt e10s stylo10,413.40 -> 10,321.40

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=15153