1483027 - Three dotted icon menu is hard to discover in New tab page

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Alice0775 White]

There are 2 kind of three dot icon.
One is for each thumbnails. And the other is for Top Sites/Highlights.

Actual Results:
There are not obvious explanation what is this.

Expected Results:
Easy to find them, Menu items in three dot icon should be aggregated in right click menu of thumbnail.
At least, tooltip should be provided for three dot icon.

Comment 1

[Alice0775 White]

Attachment: screenshot

Three dot icon.
Right click menu and Three dot icon menu.

Comment 2

[Aaron Benson]

Top Sites have actions associated with them that do not make sense for Highlights (or Pocket Stories) and vice-versa so we're using a generic icon to indicate the menu. 

I DO think that the icon could benefit from a tooltip (perhaps, "Options" or "Menu") that would help to describe what the button does.

As for the discrepancy between the three-dot menu and the mouse right-click (system) menu, that's an entirely different issue and should be taken up in another bug (if it hasn't already).

Comment 3

[Tim Spurway [:tspurway]]

let's add a tooltip to this

Comment 4

[Divyansh Sharma [:spiro]]

Tim

I want to fix this bug. Which file(s) should I look up to for resolving this bug?

Thanks.

Comment 5

[Tim Spurway [:tspurway]]

Hi Divyansh,

Thanks for your interest in this bug!  We'd love to help you help us!

I am going to pass this needinfo onto someone who can actually help.  :ursula can you point Divyansh at some code?

Comment 6

[Ursula Sarracini (:ursula)]

Hey Divyansh, you'll want to add a title attribute to the React components called TopSite: https://github.com/mozilla/activity-stream/blob/master/content-src/components/TopSites/TopSite.jsx#L282, similarly in Card.jsx, and CollapsibleSection.jsx. All the components that have the class name "context-menu-button" is what you're looking for here. Additionally you'll have to add the string "Menu" to our strings.properties files for localization: https://github.com/mozilla/activity-stream/blob/master/locales/en-US/strings.properties. You can add it at the bottom with a comment above it describing that this is a tooltip for the the context menu. 
The pull request should be done against this repo: https://github.com/mozilla/activity-stream
Does that give you enough to get started? If you have any more questions about this, feel free to ask!

Comment 7

[Arshad Kazmi [:arshadkazmi42]]

Is this still available, I would like to take this up.

Comment 8

[Ursula Sarracini (:ursula)]

Sure thing, I'll assign you :)

Comment 9

[Arshad Kazmi [:arshadkazmi42]]

Thanks Ursula.
Just to confirm, I need to create a Pull Request against this repo for this?

https://github.com/mozilla/activity-stream

Comment 10

[Arshad Kazmi [:arshadkazmi42]]

Created a PR here

https://github.com/mozilla/activity-stream/pull/4499

Comment 11

[Ursula Sarracini (:ursula)]

Yes, thank you, we'll get someone to review it!

Comment 12

[Ed Lee :Mardak]

Should the hover text/title be an action, e.g., "List all tabs" "Open a new tab" "Show sidebars" "Open menu"

So in this case, maybe just "Open menu"? And should that same title be used for menus of top sites, stories/cards, and sections?

Comment 13

[Aaron Benson]

That's a good catch, Ed. I think you're right and it should be an action. "Open menu" works for all of the ••• items.

Comment 14

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e58a97b309a519c1ae1f1a654cf90d8398849b33
Fix Bug 1483027 - Add title to three doted menu in home (#4499)

Comment 15

[Ed Lee :Mardak]

Thanks for the fix! You should be able to see it in the latest Nightly 64 (20181018123730)

Comment 16

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/826cd78b94cb

Comment 17

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible, the "Open menu" tooltip is displayed when any "•••" is hovered on Windows 10 x64, Mac 10.13.3, and Arch Linux x64.

Comment 18

[Arshad Kazmi [:arshadkazmi42]]

Thank you, Ciprian, for verifying this.