1483088 - Allow System Addons to Set _insertBeforeActionID

Status: RESOLVED INACTIVE

(WebExtensions :: Frontend, enhancement, P2)

Description

[Barry Chen]

When Screenshots changed from a Photon page action to a WebExtension one, its menu item in the meatball menu moved from the list of built-in actions to the list of alpha-sorted web extensions.

Screenshots' Photon page action had a `_insertBeforeActionID` property that allowed it to be appended to the list of built-in actions (https://dxr.mozilla.org/mozilla-central/source/browser/modules/PageActions.jsm#207).

Perhaps web extensions with the `mozillaAddons` permission should be allowed to set `_insertBeforeActionID`?

Comment 1

[Rob Wu [:robwu]]

This is within the scope of bug 1370735.
( https://bugzilla.mozilla.org/show_bug.cgi?id=1370735#c3 )

The

Comment 2

[Rob Wu [:robwu]]

Oops, I only wanted to change the component.

Disregard the above comment; I mistook the menu for a context menu but this is about the action button.

Comment 3

[Mike Conca [:mconca]]

This is being tracked in bug 1483591.

Comment 4

[Kris Maglione [:kmag]]

(In reply to Mike Conca [:mconca] (Denver, CO, USA UTC-6) from comment #3)
> This is being tracked in bug 1483591.

I'm not sure this is a dupe. Screenshots currently explicitly specifies its insertion position, which means that even if we treat it as if it were a built-in page action, we still need to add an extra manifest property to allow it to specify that position. They should probably be treated as separate bugs.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Is this still needed? If not please close.

Comment 6

[Barry Chen]

I haven't been involved with Screenshots for quite some time, so I'm uncertain if it still needs this. Closing.

Comment 7

[Drew Willcoxon :adw]

Me either, but this hasn't had any activity in a while.