1483097 - fix product home page to work without build/version information

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pages in Crash Stats all have a header that has a drop down of products and one of versions and then a dropdown of several pages you can go to.

If you go to the product home page it throws an HTTP 404 if the product you're trying to visit doesn't exist in the "versions" dict in the context generated to power those drop downs in the header.

In order to support products for which we have no build or version information, we need to redo the product home page to work if there's no version information.

This covers that work.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4556: fix bug 1483097: fix product home

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I talked with Lonnen for a bit and we decided the smallest/easiest step to fix this is to fix build_default_context to use super search facet if there's no data in product_versions.

I also changed the products drop down to pull from the products table rather than the product_versions table.

That creates the problem as detailed with exquisiteness in bug #1483318. We'll fix that there. It involves a migration.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/088b6f1d6d8e24b12b16635658f5ef7445b87c6f
fix bug 1483097: fix product home when there's no build/version info

This fixes the product home when there's no information for that product
in product_versions. When that happens, build_default_context will pull
the version data from super search.

This also fixes the navigation bar to display products in context["products"]
so all products will show up regardless of whether they have version
info or not.

https://github.com/mozilla-services/socorro/commit/d060ad56bd35aecc2bcf39fbf7529f90c16ceca9
Merge pull request #4556 from willkg/1483097-product-home

fix bug 1483097: fix product home

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

It looks fine on stage except one thing: the versions aren't sorted quite right.

https://crash-stats.allizom.org/home/product/B2G

That shows a bunch of beta and alpha versions, but release > beta > alpha, so I think the sorting isn't right.

I think we need to implement a version sorting function or a key builder or something.

Reopening to do that and fix build_default_context accordingly.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4557: fix bug 1483097: fix version sorting in product home page

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/d3252f66997406d09b0cbeee63d23494f429ab1b
fix bug 1483097: fix version sorting for versions info

This fixes version sorting for the product home page for products that don't
have version information in product_versions. It tries to deal with
alphas, betas, esr, and junk data.

https://github.com/mozilla-services/socorro/commit/c78c78f1883447c8ab0ef4b5583fb46f4f27fbd3
Merge pull request #4557 from willkg/1483097-version-sort

fix bug 1483097: fix version sorting in product home page