1483121 - generate static atom hash in StaticAtoms.py

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Cameron McCormack (:heycam)]

Currently static atom hashes are generated at compile time by reference to a constexpr mozilla::HashString function.  In bug 1474793 I need to know the hash value at Rust compile time too.  To avoid duplication, I will move the hash generation into StaticAtoms.py so that both nsGkAtoms.cpp and regen-atoms.py can access it.

Comment 1

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff5ac5586c4c9dc7153bb0cdf86865691b78311e

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1483121 - Generate static atom hash in StaticAtoms.py. r?njn,emilio

Depends On D3286

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8999839 [details]
Bug 1483121 - Generate static atom hash in StaticAtoms.py. r?njn,emilio

Emilio Cobos Álvarez (:emilio) has approved the revision.

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8999839 [details]
Bug 1483121 - Generate static atom hash in StaticAtoms.py. r?njn,emilio

Nicholas Nethercote [:njn] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a8334bbcf45
Generate static atom hash in StaticAtoms.py. r=njn,emilio

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out because Bug 1482782 was backed out and it was conflicting on "xpcom/ds/nsGkAtoms.cpp".

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3f6f10edab2
Backed out 8 changesets (bug 1483121, bug 1482782) for build bustages on nsDirectoryService.cpp. CLOSED TREE

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6a44943b177
Generate static atom hash in StaticAtoms.py. r=njn,emilio

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/e6a44943b177