Closed
Bug 1483121
Opened 4 years ago
Closed 4 years ago
generate static atom hash in StaticAtoms.py
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
Currently static atom hashes are generated at compile time by reference to a constexpr mozilla::HashString function. In bug 1474793 I need to know the hash value at Rust compile time too. To avoid duplication, I will move the hash generation into StaticAtoms.py so that both nsGkAtoms.cpp and regen-atoms.py can access it.
Assignee | ||
Comment 1•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff5ac5586c4c9dc7153bb0cdf86865691b78311e
Assignee | ||
Comment 2•4 years ago
|
||
Depends On D3286
Comment 3•4 years ago
|
||
Comment on attachment 8999839 [details] Bug 1483121 - Generate static atom hash in StaticAtoms.py. r?njn,emilio Emilio Cobos Álvarez (:emilio) has approved the revision.
Attachment #8999839 -
Flags: review+
![]() |
||
Comment 4•4 years ago
|
||
Comment on attachment 8999839 [details] Bug 1483121 - Generate static atom hash in StaticAtoms.py. r?njn,emilio Nicholas Nethercote [:njn] has approved the revision.
Attachment #8999839 -
Flags: review+
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0a8334bbcf45 Generate static atom hash in StaticAtoms.py. r=njn,emilio
Comment 6•4 years ago
|
||
Backed out because Bug 1482782 was backed out and it was conflicting on "xpcom/ds/nsGkAtoms.cpp".
Flags: needinfo?(cam)
Backout by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f3f6f10edab2 Backed out 8 changesets (bug 1483121, bug 1482782) for build bustages on nsDirectoryService.cpp. CLOSED TREE
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6a44943b177 Generate static atom hash in StaticAtoms.py. r=njn,emilio
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(cam)
Comment 9•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e6a44943b177
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•4 years ago
|
Assignee: nobody → cam
You need to log in
before you can comment on or make changes to this bug.
Description
•