Apply miscompilation fix from clang upstream

RESOLVED FIXED in Firefox 63

Status

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla63

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

We have a work around in the tree for a specific instance of miscompilation, but it could be happening in less obvious places, and on more platforms than just linux32, so apply the upstream fix everywhere.
Attachment #8999831 - Flags: review?(core-build-config-reviews)
Attachment #8999831 - Attachment is obsolete: true
Attachment #8999831 - Flags: review?(core-build-config-reviews)
Attachment #8999833 - Flags: review?(core-build-config-reviews)
Attachment #8999833 - Attachment is obsolete: true
Attachment #8999833 - Flags: review?(core-build-config-reviews)
Attachment #8999837 - Flags: review?(core-build-config-reviews)
Comment on attachment 8999837 [details] [diff] [review]
Apply miscompilation fix from clang upstream

Review of attachment 8999837 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/build-clang/clang-win64.json
@@ +14,5 @@
>      "cxx": "cl.exe",
>      "ml": "ml64.exe",
>      "patches": [
> +      "loosen-msvc-detection.patch",
> +      "r339636.patch"

Do we need the same patch in clang-win32.json?
Attachment #8999837 - Flags: review?(core-build-config-reviews) → review+
There is no such file in my tree.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d04a3f89940
Apply miscompilation fix from clang upstream. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/0d04a3f89940
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.