Closed Bug 1483132 Opened Last year Closed Last year

Make EditorBase::AreNodesSameType() non-virtual

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

Attachments

(1 file)

EditorBase::AreNodesSameType() is overridden only by HTMLEditor and it's enough simple to check it in EditorBase.  So, let's make it non-virtual since it's called a lot from condition of a loop in JoinNodesDeepWithTransaction().
EditorBase::AreNodesSameType() is overridden only by HTMLEditor and the
implementation is enough simple to re-implement in EditorBase.

Additionally, this is called from condition of a loop in
JoinNodesDeepWithTransaction().  So, the virtual call cost may make damage
to the performance.
Comment on attachment 9001460 [details]
Bug 1483132 - Make EditorBase::AreNodesSameType() non-virtual

Makoto Kato [:m_kato] has approved the revision.
Attachment #9001460 - Flags: review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/fd90e385d65b
Make EditorBase::AreNodesSameType() non-virtual r=m_kato
https://hg.mozilla.org/mozilla-central/rev/fd90e385d65b
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.