Closed
Bug 1483132
Opened 6 years ago
Closed 6 years ago
Make EditorBase::AreNodesSameType() non-virtual
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
Details
Attachments
(1 file)
EditorBase::AreNodesSameType() is overridden only by HTMLEditor and it's enough simple to check it in EditorBase. So, let's make it non-virtual since it's called a lot from condition of a loop in JoinNodesDeepWithTransaction().
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f407a81d9eeeef88de27085e6e9e05873c21636e
|
|
Assignee | |
Comment 2•6 years ago
|
||
EditorBase::AreNodesSameType() is overridden only by HTMLEditor and the implementation is enough simple to re-implement in EditorBase. Additionally, this is called from condition of a loop in JoinNodesDeepWithTransaction(). So, the virtual call cost may make damage to the performance.
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9001460 [details] Bug 1483132 - Make EditorBase::AreNodesSameType() non-virtual Makoto Kato [:m_kato] has approved the revision.
Attachment #9001460 -
Flags: review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/fd90e385d65b Make EditorBase::AreNodesSameType() non-virtual r=m_kato
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fd90e385d65b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•