1483134 - Inspector/3-pane scroll bar expands over headers on zoom or devTools height resize

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screen Shot 2018-08-14 at 09.39.49.png

[Affected versions]:
- Firefox 62.0b16, 63.0a1 (2018-08-13), 61.0.2, 60.1.0esr

[Affected platforms]:
- macOS 10.13, Win 8x64, Ubuntu 16.04LTS

[Steps to reproduce]:
1. Launch Firefox;
2. Enable devTools - inspector tab;
3a. Move the mouse inside the devTools section and zoom in a couple of times;
3b. Grab the devTools section and shrink it(by its height);

[Expected result]:
- Inspector/3-pane scroll bar should not expand over headers on zoom and/or devTools height resize

[Actual result]:
- the scroll bar expands and overlaps the headers

[Additional notes]:
- reproducible with the 3-pane feature turned both on and off;
- trying to scroll in the section but on the headers the content bellow is not scrolled, but the bar is still moving up/down;
- attached screenshot with the issue;
- link with recording for the behavior:
http://g.recordit.co/yldif5cD9Q.gif

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1483134.patch [1.0]

Comment 2

[Razvan Caliman [:rcaliman]]

Comment on attachment 9000086 [details] [diff] [review]
1483134.patch [1.0]

I wasn't able to reproduce the issue to begin with. But the fix is small and doesn't seem to negatively impact anything else so I guess it's fine.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38eb12ded659
Add an overflow: hidden to the inspector-responsive-container. r=rcaliman

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/38eb12ded659

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Given that it's a one-liner CSS fix, let's request Beta and ESR60 approval on this.

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9000086 [details] [diff] [review]
1483134.patch [1.0]

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Inspector/3-pane scroll bar should not expand over headers on zoom and/or devTools height resize
[Is this code covered by automated tests?]: No, just a CSS change
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Yes 
[Steps to reproduce]:
1. Launch Firefox;
2. Enable devTools - inspector tab;
3a. Move the mouse inside the devTools section and zoom in a couple of times;
3b. Grab the devTools section and shrink it(by its height);
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just a CSS change
[String changes made/needed]: None

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: Inspector/3-pane scroll bar should not expand over headers on zoom and/or devTools height resize
Fix Landed on Version: 63
Risk to taking this patch (and alternatives if risky): Not risky, just a CSS change
String or UUID changes made by this patch: None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9000086 [details] [diff] [review]
1483134.patch [1.0]

Trivial CSS one-liner for a bit of UI ugliness. Approved for 62.0b20 and ESR 60.2.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/87dfc0a599ff

Comment 9

[Cristian Fogel [:cfogel]]

Issue is still reproducible on 62.0b19.

Comment 10

[Cristian Fogel [:cfogel]]

Sorry guys, didn't notice the version it was intended to be released over. 
Updated and corrected that part.

However, the issue still reproduces over nightly(63.0a1 (2018-08-21) when the zoom_in is to the max (CTRL+ / CMD+).

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/c1c4fbe5d3b2

Comment 12

[Cristian Fogel [:cfogel]]

Hey Gabriel, 

Regarding the issue mentioned in Comment 10, is it something what can be fixed here or should we open a new bug for it?
Thank you!

Comment 13

[Ionuț Goldan [:igoldan]]

DAMP perf wins:

== Change summary for alert #15340 (as of Tue, 21 Aug 2018 16:29:02 GMT) ==

Improvements:

  6%  damp windows10-64 opt e10s stylo     80.44 -> 75.89

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=15340

Comment 14

[Cristian Fogel [:cfogel]]

While the posted issue is fixed(confirmed with 64.0b5 and 65.0a1 as well), there is still a scenario that came uncovered while verifying this; see comment 10.

Closing this issue and opening another follow up bug since it's a slightly different scenario.
New bug: 1504138