1483166 - Refactor evalWithDebugger in the webconsole actor

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P4)

Description

[Yulia Startsev [:yulia]]

The evalWithDebugger is a very large, complex function that is difficult to modify or work with. this could be improved by splitting it up into smaller parts.

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1483166 - refactor evalWithDebugger into its own file; r=nchevobbe,bhackett

this combines the changes that I made in bug 1464461
(https://reviewboard.mozilla.org/r/253132/diff/1#index_header) with the changes for web replay made
by Brian Hackett, along with some clean up that was done by Honza with regards to helpers being
executed. This change should not have any functional impact on the code base, but it should make it
easier to work with the evalWithDebugger functionality than it has been so far.

Comment 2

[Yulia Startsev [:yulia]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=15eaafa654874ef29f7ad728520940149d542845

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8999876 [details]
Bug 1483166 - refactor evalWithDebugger into its own file; r=nchevobbe,bhackett

Nicolas Chevobbe [:nchevobbe] has approved the revision.

Comment 4

[Yulia Startsev [:yulia]]

new try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e97f7b62c75921b88ca1de28fb7779fcb432ddb

Comment 5

[Brian Hackett [Laid off!]]

Comment on attachment 8999876 [details]
Bug 1483166 - refactor evalWithDebugger into its own file; r=nchevobbe,bhackett

Brian Hackett (:bhackett) has approved the revision.

Comment 6

[Yulia Startsev [:yulia]]

new try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d0aaa49341a68393eee0ee9e5237b95bbc873e6

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fda28e376a50
refactor evalWithDebugger into its own file; r=nchevobbe,bhackett

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out changeset fda28e376a50 (Bug 1483166) for mochitest-chrome failures on devtools/shared/webconsole/test/test_jsterm.html.

Backout: https://hg.mozilla.org/integration/autoland/rev/da9bb0adc743fda1f6272431c6728d68f0b4046a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fda28e376a50af065003f1594b9b57d083e27be8&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=194875541

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194875541&repo=autoland&lineNumber=160883

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd0422cab7e8
refactor evalWithDebugger into its own file; r=nchevobbe,bhackett

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cd0422cab7e8