Refactor evalWithDebugger in the webconsole actor

RESOLVED FIXED in Firefox 63

Status

enhancement
P4
trivial
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: yulia, Assigned: yulia)

Tracking

unspecified
Firefox 63

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

The evalWithDebugger is a very large, complex function that is difficult to modify or work with. this could be improved by splitting it up into smaller parts.
Severity: normal → trivial
Assignee: nobody → ystartsev
this combines the changes that I made in bug 1464461
(https://reviewboard.mozilla.org/r/253132/diff/1#index_header) with the changes for web replay made
by Brian Hackett, along with some clean up that was done by Honza with regards to helpers being
executed. This change should not have any functional impact on the code base, but it should make it
easier to work with the evalWithDebugger functionality than it has been so far.
Comment on attachment 8999876 [details]
Bug 1483166 - refactor evalWithDebugger into its own file; r=nchevobbe,bhackett

Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #8999876 - Flags: review+
Comment on attachment 8999876 [details]
Bug 1483166 - refactor evalWithDebugger into its own file; r=nchevobbe,bhackett

Brian Hackett (:bhackett) has approved the revision.
Attachment #8999876 - Flags: review+
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fda28e376a50
refactor evalWithDebugger into its own file; r=nchevobbe,bhackett
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd0422cab7e8
refactor evalWithDebugger into its own file; r=nchevobbe,bhackett
https://hg.mozilla.org/mozilla-central/rev/cd0422cab7e8
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Flags: needinfo?(ystartsev)
You need to log in before you can comment on or make changes to this bug.