1483173 - Create Screenshot Actor

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Description

[Yulia Startsev [:yulia]]

We have a few places that need screenshot functionality: the toolbox buttons, the inspector menu, the console, and the webIDE -- we should move the existing screenshot code to a shared helper and expose it via a screenshot actor

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1483173 - introduce screenshot actor; r=ochameau

This patch introduces a screenshot actor, which allows the screenshot functionality to be
shared across tools, and also implements it for the toolbox itself

Comment 2

[Yulia Startsev [:yulia]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=883a30e161d45c0c116261480cf0468af33b66e9

Comment 3

[Yulia Startsev [:yulia]]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc3a6bfe9352821f37b9d7854663394bf899577f

Comment 4

[Yulia Startsev [:yulia]]

try run: https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=16d616e7096c2807b4299f0d07db657759b049c6

Comment 5

[Yulia Startsev [:yulia]]

try run:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1c7cb2baca03e6d069fc6f66f462eb3714f8895

Comment 7

[Alexandre Poirot [:ochameau]]

Comment on attachment 8999964 [details]
Bug 1483173 - introduce screenshot actor; r=ochameau

Alexandre Poirot [:ochameau] has approved the revision.

Comment 8

[Yulia Startsev [:yulia]]

try results for revision: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3549a8a02052eafb1caa775f36d440861f06d9c5

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f7d58a640b8
introduce screenshot actor; r=ochameau

Comment 10

[Andrei Ciure[:aciure]]

Backed out changeset 4f7d58a640b8 (bug 1483173) for browser_jsterm_screenshot_command_clipboard.js failures

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4f7d58a640b8d4872fad4c2589f8c934f7e0b246&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=564d9c60d6e2722f396f8918f42735d87060a14b&group_state=expanded&selectedJob=195080882&filter-searchStr=Linux+debug+Mochitests+test-linux32%2Fdebug-mochitest-clipboard+M%28cl%29

log: https://treeherder.mozilla.org/logviewer.html#?job_id=195080882&repo=autoland

backout: https://hg.mozilla.org/integration/autoland/rev/6c479457064ffd32edfdb78fd43538a87f17dd55

Comment 11

[Yulia Startsev [:yulia]]

Andrei, do you have any more information regarding this? I cannot reproduce it locally or on try.

Try run with the original push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3549a8a02052eafb1caa775f36d440861f06d9c5

Try run rebased on today's central: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de2352faeec144d5aee8bd1cb1ad02f251b5a7da

Comment 12

[Yulia Startsev [:yulia]]

I see, it is due to it being on linux 32 bit. i will see what is happening

Comment 13

[Yulia Startsev [:yulia]]

new try run: Bug 1483173 - introduce screenshot actor; r=ochameau

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41ccbc9bc2b2
introduce screenshot actor; r=ochameau

Comment 15

[Yulia Startsev [:yulia]]

wrong link for the try run; here is the right one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c72f6dd13ad10150fc9620749a8a90ec9b1a6d8&selectedJob=196093102

Comment 16

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/41ccbc9bc2b2