1483190 - Android 4.0 L10n nightlies broken: mozbuild.configure.options.InvalidOptionError: --enable-lto is not available in this configuration

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Latest push with Nightlies:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=914b3b370ad059a04ad751642b74e013f8e3ad08&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&selectedJob=193836951

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=193836951&repo=mozilla-central

[task 2018-08-14T10:44:15.929Z] 10:44:15     INFO -   0:02.73 checking for vcs source checkout... hg
[task 2018-08-14T10:44:15.932Z] 10:44:15    ERROR -   0:02.74 Traceback (most recent call last):
[task 2018-08-14T10:44:15.932Z] 10:44:15     INFO -   0:02.74   File "/builds/worker/workspace/build/src/configure.py", line 123, in <module>
[task 2018-08-14T10:44:15.933Z] 10:44:15     INFO -   0:02.74     sys.exit(main(sys.argv))
[task 2018-08-14T10:44:15.933Z] 10:44:15     INFO -   0:02.74   File "/builds/worker/workspace/build/src/configure.py", line 29, in main
[task 2018-08-14T10:44:15.933Z] 10:44:15     INFO -   0:02.74     sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
[task 2018-08-14T10:44:15.933Z] 10:44:15     INFO -   0:02.74   File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 409, in run
[task 2018-08-14T10:44:15.934Z] 10:44:15     INFO -   0:02.74     self._value_for(option)
[task 2018-08-14T10:44:15.934Z] 10:44:15     INFO -   0:02.74   File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 477, in _value_for
[task 2018-08-14T10:44:15.934Z] 10:44:15     INFO -   0:02.74     return self._value_for_option(obj)
[task 2018-08-14T10:44:15.934Z] 10:44:15     INFO -   0:02.74   File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/util.py", line 944, in method_call
[task 2018-08-14T10:44:15.935Z] 10:44:15     INFO -   0:02.74     cache[args] = self.func(instance, *args)
[task 2018-08-14T10:44:15.935Z] 10:44:15     INFO -   0:02.74   File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 542, in _value_for_option
[task 2018-08-14T10:44:15.935Z] 10:44:15     INFO -   0:02.74     % option_string.split('=', 1)[0])
[task 2018-08-14T10:44:15.935Z] 10:44:15     INFO -   0:02.74 mozbuild.configure.options.InvalidOptionError: --enable-lto is not available in this configuration
[task 2018-08-14T10:44:15.956Z] 10:44:15     INFO -   0:02.76 *** Fix above errors and then restart with\
[task 2018-08-14T10:44:15.957Z] 10:44:15     INFO -   0:02.76                "/usr/bin/make -f client.mk build"
[task 2018-08-14T10:44:15.957Z] 10:44:15     INFO -   0:02.76 client.mk:123: recipe for target 'configure' failed
[task 2018-08-14T10:44:15.957Z] 10:44:15     INFO -   0:02.76 make: *** [configure] Error 1

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Sorry, these aren't builds we actually ship, so downgrading the severity a bit.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This bustage blocks uploading Nightly

Comment 3

[Ryan VanderMeulen [:RyanVM]]

*sigh*

This bustage blocks uploading Nightly APKs to the Play Store. Re-bumping the priority.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Only enable LTO if the NDK is available

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d296e62cb8543ec243e44e7bb47113364722e243

And I also did confirm that the L10n job is broken on Try without this patch.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 9000039 [details] [diff] [review]
Only enable LTO if the NDK is available

Review of attachment 9000039 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

::: mobile/android/config/mozconfigs/android-aarch64/nightly
@@ +9,5 @@
>  export AR="$topsrcdir/clang/bin/llvm-ar"
>  export NM="$topsrcdir/clang/bin/llvm-nm"
>  export RANLIB="$topsrcdir/clang/bin/llvm-ranlib"
>  
> +# Enable LTO if the NDK is available

Nit: Periods at the end of sentences, please.  Here and throughout.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/0fc57261a269
Only enable LTO if the NDK is available. r=froydnj, a=RyanVM

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=0fc57261a269af5b3f787a48395c83ab558c3035&filter-searchStr=android%20l10n%20nightly

Comment 8

[Justin Wood (:Callek)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> *sigh*
> 
> This bustage blocks uploading Nightly APKs to the Play Store. Re-bumping the
> priority.

*sigh* android single locale bustage shouldn't break Google Play submission. I'll try to get a bug on file for this, (or someone else can before me, n-i me and jlorenzo)

Comment 9

[Intermittent Failures Robot]

24 failures in 594 pushes (0.04 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 21
* autoland: 1
* try: 2

Platform breakdown:
* android-4-0-armv7-api16: 24

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1483190&startday=2018-08-14&endday=2018-08-14&tree=all

Comment 10

[Intermittent Failures Robot]

24 failures in 2672 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 2
* mozilla-central: 21
* autoland: 1

Platform breakdown:
* android-4-0-armv7-api16: 24

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1483190&startday=2018-08-13&endday=2018-08-19&tree=all

Comment 11

[Mike Hommey [:glandium]]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1507e086acbcf9e0c60cfa7e89dd31995950e520 for multiple reasons (see commit message).

Comment 12

[Ryan VanderMeulen [:RyanVM]]

I'm going to assume that if/when bug 1480006 is ready to land again, this fix will be rolled into that.

Comment 15

[Mike Hommey [:glandium]]

I messed up the re-relanding of bug 1480006.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70b12731ca43
Only enable LTO if the NDK is available. r=froydnj, a=RyanVM

Comment 17

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/70b12731ca43

Comment 18

[Eliza Balazs [:ebalazs_]]

Backed out changeset 70b12731ca43 (Bug 1483190) for crashes on Android (Bug 1489553) a=backout

Backout push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=700e65c0ab9bb8ec1182b890bd51722b95eb0f24

Comment 19

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/9d294202030e
Backed out changeset 70b12731ca43 for crashes on Android (bug 1489553) a=backout

Comment 20

[Ryan VanderMeulen [:RyanVM]]

That bug number makes no sense. Also, this change doesn't affect any builds we ship, so how can it possibly be related?

Comment 21

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Typo in the bug number, my bad. Should be bug 1489953.

Comment 22

[Mike Hommey [:glandium]]

This bug was to fix the l10n/artifact bustage from bug 1483190. And the relanding of bug 1483190 yesterday didn't include it like the previous attempt. And it was backed out again.

Comment 23

[Liz Henry (:lizzard) (relman/hg->git project)]

Ryan or Mike, what needs to happen here?

Comment 24

[Ryan VanderMeulen [:RyanVM]]

Nothing at the moment. Just needs to re-land whenever bug 1480006 is ready for another try.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

This was included in the relanded patch for bug 1480006.
https://hg.mozilla.org/mozilla-central/rev/5ab46880d921