1483212 - Perma-failing damp | webconsole/autocomplete.js: Test timed out when Gecko 63 merges to Beta on 2018-08-27

Status: VERIFIED FIXED

(Testing :: Talos, defect)

Description

[Andreea Pavel [:apavel]]

[Tracking Requested - why for this release]:

Central as Beta Simulation

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f2fbccfc0a525116d76c93a563bbdee252635e3&group_state=expanded&selectedJob=193859969&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=193859969&repo=try&lineNumber=1232

Nicolas can you please take a look?

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Did the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=1482826 was applied ?

Comment 2

[Andreea Pavel [:apavel]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #1)

Yes, that patch was applied.

Comment 3

[Andreea Pavel [:apavel]]

Let me be more specific:

This started perma-failing since yesterday's beta-sim 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=298c8176c9352679e2287fffa7228013f11f1038&filter-searchStr=Windows%207%20opt%20Talos%20performance%20tests%20with%20e10s%20test-windows7-32%2Fopt-talos-damp-e10s%20T-e10s(damp)&selectedJob=193867489

For that, the patch was not applied.

However, in today's beta-sim, the patch is applied and the failure still appears.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Andreea, is there a way I can try to reproduce that locally ? The logs are not helpful enough to debug this properly.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Nicolas, get the base config and early beta changeset from https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f2fbccfc0a525116d76c93a563bbdee252635e3&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Name for the Try syntax is "damp": https://dxr.mozilla.org/mozilla-central/rev/4e56a2f51ad739ca52046723448f3129a58f1666/taskcluster/ci/test/talos.yml#94

I have no recent experience with running Talos locally.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Thanks aryx, I'm used to run this test locally, so I should be able to see what's going on.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

oh, now I see what's happening.

The test was adapted to work with the codeMirror JsTerm.
BUT, codeMirror jsterm is enabled only on Nightly.
Hence. the test now timing out.

Let me try to get something up real quick (end of the day here and I'm off for the rest of the week then)

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1483212 - Fix DAMP webconsole autocomplete test on Beta; r=bgrins.

In beta, we still have the old jsterm, so we need to adjust
the test code in this case. Which means reverting back
to what we were doing: manually triggering the autocompletion
start by calling updateAutoCompletion.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

A patch was posted on Phabricator. From my manual testing, it makes the test work with both old and new JsTerm.

TRY push on top of latest m-c: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b0404d37baab6b99de2d2bb1cc3c531a0a6f7ec
TRY push on top of try/7f2fbccfc0a525116d76c93a563bbdee252635e3: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d84db33ca91a94adabbefa2d6f537f3d758b611f

Comment 10

[Brian Grinstead [:bgrins]]

Comment on attachment 8999998 [details]
Bug 1483212 - Fix DAMP webconsole autocomplete test on Beta; r=bgrins.

Brian Grinstead [:bgrins] has approved the revision.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bab1274f79d
Fix DAMP webconsole autocomplete test on Beta; r=bgrins.

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9bab1274f79d

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=587dd308797a67580077316ce6da6be6a9afbff9&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 14

[Intermittent Failures Robot]

7 failures in 2672 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 7

Platform breakdown:
* linux64-nightly: 1
* windows7-32-msvc: 1
* macosx64-nightly: 1
* windows10-64-nightly: 1
* linux64-qr: 1
* linux64: 1
* osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1483212&startday=2018-08-13&endday=2018-08-19&tree=all

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

No need to track this for 63.