Closed Bug 1483245 Opened Last year Closed Last year

Add telemetry probe measuring total paint thread rasterization time

Categories

(Core :: Graphics: Layers, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

We have two probes that approximately measure our rasterization performance with OMTP enabled, GFX_OMTP_PAINT_WAIT_TIME and gfx.omtp.paint_wait_ratio.

It could be nice to have one that directly measures the time from begin to end.
I also added a probe for the amount of tasks queued in a transaction. From a quick run of opening the browser and loading a page, the histogram highs and lows seem reasonable but I will test further later.
Attachment #9002091 - Flags: review?(jmuizelaar)
Attached file data-review.txt
Attachment #9002093 - Flags: review?(francois)
Comment on attachment 9002093 [details]
data-review.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Not permanent.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON, only in pre-release channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, telemetry alerts are fine.
Attachment #9002093 - Flags: review?(francois) → review+
Attachment #9002091 - Flags: review?(jmuizelaar) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c5aa35fa3d2
Add telemetry probes for amount of time spent on paint thread and the amount of tasks. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/3c5aa35fa3d2
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.