Closed Bug 1483255 Opened Last year Closed Last year

Disabling two or more @search Top Sites doesn't disable all the selected Top Sites

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 63
Iteration:
63.4 - Aug 20
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- verified
firefox63 --- verified

People

(Reporter: cmuresan, Assigned: rrosario)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

[Affected versions]:
- Nightly v63.0a1, Build ID 20180812220618

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have all the @search Top Sites enabled.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites and open a new tab.
2. Click the "..." Top Sites section button and select the "Add Search Engine" option.
3. Deselect all the Top Sites from the modal and click the save button.
4. Observe the Top Sites section.

[Expected results]:
- The @search Top Sites are no longer displayed.

[Actual results]:
- One @search Top Site is still displayed.

[Notes]:
- When in this state, if another @search Top Site is enabled, the one that was still enabled will be disabled.
- Attached a screenshot of the issue.
Blocks: 1479806
Assignee: nobody → ahillier
Blocks: 1483375
No longer blocks: 1483375
Iteration: --- → 63.4 - Aug 20
Priority: -- → P1
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Blocks: 1483671
Assignee: ahillier → rrosario
Blocks: 1482398
I have verified that this issue is no longer reproducible on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of Firefox Beta (62.0b18) and latest "Firefox Nightly" (63.0a1 - Build ID 20180816220128) installed. Now the search shortcuts are disabled.
Status: RESOLVED → VERIFIED
I managed to reproduce the issue using an older version of Firefox (2018-08-14) on Windows 10.
I retested everything using beta 62.0b18 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13. The bug is not reproducing anymore.
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.