Closed Bug 1483256 Opened Last year Closed Last year
Record atomic accesses in Memory
Texture Read Lock
The read counter in MemoryTextureReadLock is used for synchronizing between threads, but the PR_ATOMIC macros it is implemented with are not recorded by Web Replay, and can lead to inconsistent counter values being read during replay and different behavior later on (e.g. TextureClientPool::ReturnUnlockedClients). The attached patch changes this counter to use mozilla::Atomic<>, which by default records accesses on the atomic so that they occur at consistent points during replay.
Attachment #8999971 - Flags: review?(nical.bugzilla)
Attachment #8999971 - Flags: review?(nical.bugzilla) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/0e8748072c49 Use mozilla::Atomic in MemoryTextureReadLock, r=nical.
You need to log in before you can comment on or make changes to this bug.