1483257 - Re-enabling improveSearch after starting disabled results in empty add search

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ed Lee :Mardak]

Attachment: empty add search

If one starts with improveSearch disabled but later turns it on (perhaps shield study ending), the add search dialog has no sites. See attachment.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4341

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/b2d7f56e615ac05a037176e07abed13299f6632e
Fix Bug 1483257 - update search shortcuts when enabling experiment (#4341)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/13cca9e3e12d

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible in the latest Nightly (63.0a1, Build ID 20180816100035) on Windows 10, Mac 10.13 and Arch Linux x64.

Comment 6

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is not reproducible in the latest Firefox Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Linux x64.