1483310 - Update HarfBuzz to 1.8.8

Status: RESOLVED FIXED

(Core :: Graphics: Text, enhancement, P3)

Description

[Ryan VanderMeulen [:RyanVM]]

Overview of changes leading to 1.8.8
Tuesday, August 14, 2018
====================================
- Fix hb-icu crash on architectures where compare_exchange_weak() can
  fail falsely.  This bug was introduced in 1.8.4.
  https://bugs.chromium.org/p/chromium/issues/detail?id=873568
- More internal refactoring of atomic operations and singletons.
- API changes:
  The following functions do NOT reference their return value before
  returning:
  * hb_unicode_funcs_get_default()
  * hb_glib_get_unicode_funcs()
  * hb_icu_get_unicode_funcs()
  This is consistent with their naming ("get", instead of "reference")
  as well as how they are used in the wild (ie. no one calls destroy()
  on their return value.)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Update HarfBuzz to version 1.8.8

It's green on Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=94184c1b78f2e27dbd12c83fb3547fe7d2c088ab

I'm kinda thinking right now that if we're close to the soft freeze and this is the latest version, I'll go ahead and flag for review before 63 goes to Beta. Otherwise, we can just go with whatever's the latest by then.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1483310 - Update HarfBuzz to version 1.8.8. r=jfkthame

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 9003127 [details]
Bug 1483310 - Update HarfBuzz to version 1.8.8. r=jfkthame

Jonathan Kew (:jfkthame) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5874c9b590a0
Update HarfBuzz to version 1.8.8. r=jfkthame

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5874c9b590a0