Intermittent browser/components/extensions/test/browser/test-oop-extensions/browser_ext_sidebarAction.js | message queue is empty - Got ["sidebar"], expected []

RESOLVED FIXED

Status

defect
RESOLVED FIXED
10 months ago
5 months ago

People

(Reporter: intermittent-bug-filer, Assigned: Gijs)

Tracking

({intermittent-failure})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [retriggered][stockwell fixed])

Attachments

(1 attachment)

Reporter

Description

10 months ago
treeherder
Filed by: csabou [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=193898762&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/Cvxcor0GQJ-j4JMi_yS-Vg/runs/0/artifacts/public/logs/live_backing.log

[task 2018-08-14T17:00:36.306Z] 17:00:36     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/test-oop-extensions/browser_ext_sidebarAction.js | message queue is empty - Got ["sidebar"], expected []
[task 2018-08-14T17:00:36.307Z] 17:00:36     INFO - Stack trace:
[task 2018-08-14T17:00:36.308Z] 17:00:36     INFO - chrome://mochikit/content/browser-test.js:test_is:1308
[task 2018-08-14T17:00:36.308Z] 17:00:36     INFO - chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:27
[task 2018-08-14T17:00:36.309Z] 17:00:36     INFO - chrome://mochikit/content/browser-test.js:nextTest:708
[task 2018-08-14T17:00:36.310Z] 17:00:36     INFO - chrome://mochikit/content/browser-test.js:testScope/test_finish/<:1400
[task 2018-08-14T17:00:36.311Z] 17:00:36     INFO - chrome://mochikit/content/browser-test.js:run:1337
[task 2018-08-14T17:00:36.312Z] 17:00:36     INFO - GECKO(1067) | MEMORY STAT | vsize 20975643MB | residentFast 2228MB
Comment hidden (Intermittent Failures Robot)
In the last 7 days, there are 47 failures.

They occur on windows7-32 (debug), windows10-64 (debug), osx-10-10 (debug), linux64 (debug, asan, pgo), linux32 (debug).

Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=195066572&repo=mozilla-inbound&lineNumber=26954

:ddurst, Could you please have a look at this?
Flags: needinfo?(ddurst)
Whiteboard: [stockwell needswork:owner]
Comment hidden (Intermittent Failures Robot)

Comment 6

10 months ago
My changes probably improved the performance of some operations, making some existing race condition in the test more common.

It might be more efficient if someone familiar with the test in question takes a first look, and then if they find nothing I can help and see if there is anything I can do in the sidebar code.
Flags: needinfo?(paolo.mozmail)

Updated

10 months ago
Priority: P5 → --
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Attachment #9004160 - Flags: review?(jmaher)
Attachment #9004160 - Flags: review?(jmaher) → review+
Whiteboard: [retriggered][stockwell disable-recommended] → [retriggered][stockwell disabled]

Comment 14

10 months ago
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e41a430f9d2e
Disable browser/components/extensions/test/browser/test-oop-extensions/browser_ext_sidebarAction.js on all debug tests. r=jmaher
Keywords: checkin-needed
Comment hidden (Intermittent Failures Robot)
Assignee

Comment 17

10 months ago
AFAICT all that needs to happen here is that this block:

https://searchfox.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_sidebarAction.js#69-80

needs to call:

await extension.awaitMessage("sidebar");

after

  await extension.startup();

(and before unloading) just like all the other tests that open the add-on's sidebar - which triggers loading the add-on's document, which sends the 'sidebar' message - to avoid triggering the asserts here ( https://searchfox.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/ExtensionTestUtils.js#24-33 ) as the test ends.

:mixedpuppy, can you check if that makes sense to you? If you have time, land that with r=me (together with re-enabling this on debug) and we should be good, I think... Or I can land it with rs=you if it looks OK, after I get some sleep.

(I ran into this issue on my trypush.)
Flags: needinfo?(mixedpuppy)
That looks right to me.
Flags: needinfo?(mixedpuppy)

Comment 20

10 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e8684ce7609
re-enable sidebar test after checking for correct messages to get them out of the queue, rs=mixedpuppy
Assignee

Updated

10 months ago
Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [retriggered][stockwell disabled] → [retriggered]
Comment hidden (Intermittent Failures Robot)
Whiteboard: [retriggered][stockwell disable-recommended] → [retriggered][stockwell disabled]

Comment 23

5 months ago

I'm updating the whiteboard field and mark this as "resolved,fixed", as this test is not disabled since https://hg.mozilla.org/mozilla-central/rev/4e8684ce7609 and it doesn't seem that new intermittent failures has been collected for this bugzilla issue in the last few months.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → RESOLVED
Closed: 5 months ago
Flags: needinfo?(ddurst)
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [retriggered][stockwell disabled] → [retriggered][stockwell fixed]
You need to log in before you can comment on or make changes to this bug.