Write a CacheIR test case for comparisons involving an HTMLDDA object

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
Last year
2 months ago

People

(Reporter: mgaudet, Assigned: vi.le, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

Trunk
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 wontfix, firefox68 fixed)

Details

Attachments

(1 attachment)

js/src/jit-test/tests/cacheir/compare.js should be modified to add test cases that use the builtin createIsHTMLDDA [1] to make sure that the CacheIR compare handling for these exotic objects doesn't regress

The important oddities of these objects are documented in the ECMAScript standard [2], Section B.3.7

[1]: https://searchfox.org/mozilla-central/rev/2466b82b729765fb0a3ab62f812c1a96a7362478/js/src/shell/js.cpp#7338  
[2]: https://tc39.github.io/ecma262/#sec-IsHTMLDDA-internal-slot
Component: JavaScript Engine → JavaScript Engine: JIT
Mentor: mgaudet
Priority: -- → P3

Can I work on this? :-)

Flags: needinfo?(mgaudet)

Hey, it's definitely free for the taking.

Where you'd want to add test cases is https://searchfox.org/mozilla-central/source/js/src/jit-test/tests/cacheir/compare.js

You'll want to test all the ways in which an IsHTMLDDA object differ from regular objects.

You'll want to build the SpiderMonkey shell and then test it using ../jit-test/jit_test.py --jitflags=all ./dist/bin/js cacheir/compare.js.

Flags: needinfo?(mgaudet)
Assignee: nobody → vi.le
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da9552ba5fec
Add CacheIR test case for HTMLDDA object;r=mgaudet

Thanks so much for this! Let me know if you need help finding another bug to jump on.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.