1483340 - Write a CacheIR test case for comparisons involving an HTMLDDA object

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

js/src/jit-test/tests/cacheir/compare.js should be modified to add test cases that use the builtin createIsHTMLDDA [1] to make sure that the CacheIR compare handling for these exotic objects doesn't regress

The important oddities of these objects are documented in the ECMAScript standard [2], Section B.3.7

[1]: https://searchfox.org/mozilla-central/rev/2466b82b729765fb0a3ab62f812c1a96a7362478/js/src/shell/js.cpp#7338  
[2]: https://tc39.github.io/ecma262/#sec-IsHTMLDDA-internal-slot

Comment 1

[Vincent Lequertier]

Can I work on this? :-)

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Hey, it's definitely free for the taking.

Where you'd want to add test cases is https://searchfox.org/mozilla-central/source/js/src/jit-test/tests/cacheir/compare.js

You'll want to test all the ways in which an IsHTMLDDA object differ from regular objects.

You'll want to build the SpiderMonkey shell and then test it using ../jit-test/jit_test.py --jitflags=all ./dist/bin/js cacheir/compare.js.

Comment 3

[Vincent Lequertier]

Attachment: Bug 1483340 - Add CacheIR test case for HTMLDDA object;r=mgaudet

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da9552ba5fec
Add CacheIR test case for HTMLDDA object;r=mgaudet

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

Thanks so much for this! Let me know if you need help finding another bug to jump on.

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/da9552ba5fec