Tooltip for Tracking Protection item in the Firefox menu uses a capitalized Preferences (and should use 'options' on Windows)
Categories
(Firefox :: Protections UI, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: jaws, Assigned: paarmita1998, Mentored)
References
Details
Attachments
(1 file)
STR: Open the Firefox menu Hover the Tracking Protection button Tooltip says "Open Tracking Protection Preferences" Expected: "Open Tracking Protection options". On Windows we use "Options" and on Mac and Linux we use "Preferences". I propose a lower case "options"/"preferences" because it is being used in the generic sense here.
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
francois, would you be willing to mentor this bug?
Comment 2•6 years ago
|
||
I think Johann would be a better candidate (if he has time) since I don't know anything about the front-end parts of tracking protection.
Comment 3•6 years ago
|
||
Yeah, so, in bug 1462468 we decided not to add the effort of making this tooltip platform dependent since the sync tooltip above isn't either, but I think it makes sense to do this as a mentored bug.
Assignee | ||
Comment 4•5 years ago
|
||
Hey,
I want to work on this issue. Can you please guide me which file needs to be changed?
Comment 5•5 years ago
|
||
Sure, thank you. I can add some more detailed instructions tomorrow (it's getting late for me).
Assignee | ||
Comment 6•5 years ago
|
||
Hey,
I could start working on this issue. Can you please provide some more info on it?
Comment 7•5 years ago
|
||
So, in the future, with Fluent, this would be quite easy.
But apparently we haven't converted that part yet, so we can just do it the old-fashioned way.
The current tooltip is defined here: https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/browser/locales/en-US/chrome/browser/browser.properties#480
And accessed here: https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/browser/base/content/browser-contentblocking.js#825
It currently says "Preferences", which isn't the term used for Windows normally. So we want to change it to say "Options" on Windows instead. You'll need to make another string for that and change the code that accesses it to check the AppConstants.platform attribute to select the right string for the right platform.
Let me know if you have any questions!
Thanks!
Assignee | ||
Comment 8•5 years ago
|
||
Hey,
Can you provide me some code example for strings in different platforms like to filter based on OS?
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 9•5 years ago
|
||
Tooltip for Tracking Protection item in the Firefox menu uses a capitalized Preferences (and should use 'options' on Windows)
Comment 10•5 years ago
|
||
This could be useful
https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/browser/base/content/browser.js#671
Also note that you'll need to pick a new string ID when you update an existing string in a significant way
https://developer.mozilla.org/en-US/docs/Making_String_Changes
Assignee | ||
Comment 11•5 years ago
|
||
Thanks, it was helpful. I will look into the code and will update the PR.
Comment 13•5 years ago
|
||
Hey, is this issue resolved?
Comment 14•5 years ago
|
||
Ah, no, this issue is not resolved yet, but Paarmita only needs to make one more change as highlighted in Phabricator and then set the checkin-needed
flag.
Thanks!
Assignee | ||
Comment 15•5 years ago
|
||
I have updated the patch with the required changes. Can you please review it?
Updated•5 years ago
|
Comment 17•5 years ago
|
||
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/432ea14d6824
Tooltip for Tracking Protection item in the Firefox menu uses a capitalized Preferences; r=johannh
Comment 18•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Description
•