Tooltip for Tracking Protection item in the Firefox menu uses a capitalized Preferences (and should use 'options' on Windows)

RESOLVED FIXED in Firefox 68

Status

()

defect
P3
normal
RESOLVED FIXED
8 months ago
29 days ago

People

(Reporter: jaws, Assigned: paarmita1998, Mentored)

Tracking

unspecified
Firefox 68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

STR:
Open the Firefox menu
Hover the Tracking Protection button

Tooltip says "Open Tracking Protection Preferences"

Expected: "Open Tracking Protection options".

On Windows we use "Options" and on Mac and Linux we use "Preferences". I propose a lower case "options"/"preferences" because it is being used in the generic sense here.
Priority: -- → P2
francois, would you be willing to mentor this bug?
Flags: needinfo?(francois)
I think Johann would be a better candidate (if he has time) since I don't know anything about the front-end parts of tracking protection.
Flags: needinfo?(francois)
Yeah, so, in bug 1462468 we decided not to add the effort of making this tooltip platform dependent since the sync tooltip above isn't either, but I think it makes sense to do this as a mentored bug.
Blocks: 1462468
Mentor: jhofmann
Priority: P2 → P3
(Assignee)

Comment 4

2 months ago

Hey,
I want to work on this issue. Can you please guide me which file needs to be changed?

Sure, thank you. I can add some more detailed instructions tomorrow (it's getting late for me).

Assignee: nobody → paarmita1998
Status: NEW → ASSIGNED
(Assignee)

Comment 6

2 months ago

Hey,
I could start working on this issue. Can you please provide some more info on it?

Flags: needinfo?(jhofmann)

So, in the future, with Fluent, this would be quite easy.

But apparently we haven't converted that part yet, so we can just do it the old-fashioned way.

The current tooltip is defined here: https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/browser/locales/en-US/chrome/browser/browser.properties#480

And accessed here: https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/browser/base/content/browser-contentblocking.js#825

It currently says "Preferences", which isn't the term used for Windows normally. So we want to change it to say "Options" on Windows instead. You'll need to make another string for that and change the code that accesses it to check the AppConstants.platform attribute to select the right string for the right platform.

Let me know if you have any questions!

Thanks!

Flags: needinfo?(jhofmann)
(Assignee)

Comment 8

2 months ago

Hey,
Can you provide me some code example for strings in different platforms like to filter based on OS?

(Assignee)

Updated

2 months ago
Flags: needinfo?(jhofmann)
(Assignee)

Comment 9

2 months ago

Tooltip for Tracking Protection item in the Firefox menu uses a capitalized Preferences (and should use 'options' on Windows)

This could be useful
https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/browser/base/content/browser.js#671

Also note that you'll need to pick a new string ID when you update an existing string in a significant way
https://developer.mozilla.org/en-US/docs/Making_String_Changes

(Assignee)

Comment 11

2 months ago

Thanks, it was helpful. I will look into the code and will update the PR.

Thanks for the help, flod :)

Flags: needinfo?(jhofmann)

Hey, is this issue resolved?

Ah, no, this issue is not resolved yet, but Paarmita only needs to make one more change as highlighted in Phabricator and then set the checkin-needed flag.

Thanks!

(Assignee)

Comment 15

a month ago

I have updated the patch with the required changes. Can you please review it?

Flags: needinfo?(jhofmann)

Looks good, you can set checkin-needed. :)

Flags: needinfo?(jhofmann)

Comment 17

a month ago

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/432ea14d6824
Tooltip for Tracking Protection item in the Firefox menu uses a capitalized Preferences; r=johannh

Keywords: checkin-needed

Comment 18

29 days ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.