1483430 - Backout fxmonitor system add-on from central and beta

Status: RESOLVED FIXED

(Firefox :: Firefox Monitor, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

It seems that m-c is just not ready for a pure web-extension system add-on. We have the following issues which have led me to decide to give up on landing this code in m-c for now:

1. Bug 1479599 has not landed in beta yet, meaning the add-on is broken in beta even in minimal form, and shows an error in the console.
2. Combined with bug 1479599, perf regression - bug 1483172. It seems like that perf cost is one that we'll have to bear at some point or the other due to loading the extension framework early, but still...
3. Difficult-to-diagnose linux64 asan failure with WebExtension Experiment API

I was really hoping this would stick so that we could continue development within m-c, giving us access to testing infrastructure and also in the interest of not having yet-another-github-repository-for-new-features. Seems like we aren't there yet. I do hope to get this code into m-c at some point, but for now, I think we should back this out.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Backout from central

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Backout from beta

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 9000143 [details] [diff] [review]
Backout from central

Review of attachment 9000143 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, that's a bummer, I'm sorry you had to go through the trouble for nothing.

I'd be interested in your alternative plan, do you intend to go through Shield? But we can talk about this on a different channel, maybe :)

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9000144 [details] [diff] [review]
Backout from beta

Approval Request Comment
[Feature/Bug causing the regression]: bug 1480610
[User impact if declined]: Console error in beta
[Is this code covered by automated tests?]: It's a backout :)
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Not really, but one can verify the patch by checking the error console and ensuring that it is free of firefox monitor related errors.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No
[Why is the change risky/not risky?]: It backs out a previous uplift
[String changes made/needed]: none

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9000144 [details] [diff] [review]
Backout from beta

Makes sense. This should land for 62 beta 18.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48bf31989df6
Backout fxmonitor system add-on from mozilla-central. r=johannh

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/59b12792683c

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/48bf31989df6