1483434 - Allow nullptr parameter for PriorVisibleNode and NextVisibleNode

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Makoto Kato [:m_kato]]

Sometimes the Caller of PriorVisibleNode or NextVisibleNode don't use outVisNode and/or outvisOffset.  But both methods require all methods and it don't allow nullptr.  It is complex whether parameter is used or unused.  So I would like to allow nullptr.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1483434 - Allow nullptr parameter for PriorVisibleNode and NextVisibleNode. r=masayuki

Sometimes the caller of PriorVisibleNode or NextVisibleNode doesn't use
outVisNode and/or outvisOffset. But both methods require all parameters and
it don't allow nullptr. It is complex whether parameter is used or unused.

So I would like to allow nullptr.

Also, this methods can change to const method, so I will change some methods
to const method too for this change.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 9000150 [details]
Bug 1483434 - Allow nullptr parameter for PriorVisibleNode and NextVisibleNode. r=masayuki

Masayuki Nakano [:masayuki] (JST, +0900) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7de9496d9640
Allow nullptr parameter for PriorVisibleNode and NextVisibleNode. r=masayuki

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/7de9496d9640