1483478 - Android AWSY test should store about:memory dumps as artifacts

Status: RESOLVED FIXED

(Testing :: General, enhancement, P2)

Description

[Mike Hommey [:glandium]]

On platforms that use the actual AWSY test, we get about:memory dumps for every measurement, which is extremely useful when looking at regressions.

But the android pseudo-AWSY test doesn't do the same, and that makes things harder to track down. For instance, for bug 1482797, I ended up patching the test to emit a dump like the real AWSY does, but couldn't figure out how to get that out of the emulator, so I ended up connecting to an interactive task on taskcluster, and manually adb pull the files when they appeared.

Comment 1

[Geoff Brown [:gbrown]]

On the host, environment variable MOZ_UPLOAD_DIR provides a magic location for artifacts. So if runtestsremote.py ran 

  self.device.pull(remote_dir, os.environ['MOZ_UPLOAD_DIR'])

then any files written to remote_dir would become available as artifacts.

I'm not sure how to share remote_dir between remote test harness and test: If runtestsremote.py uses remote_dir = '/sdcard/tests/artifacts', how does test_awsy_lite.html discover that location (or vice versa)?

Comment 2

[Geoff Brown [:gbrown]]

In my first attempt here, I tried calling

+    var memDumper = Cc["@mozilla.org/memory-info-dumper;1"].getService(Ci.nsIMemoryInfoDumper);
+    memDumper.dumpMemoryInfoToTempDir(aLabel, /* anonymize = */ false,
+                                      /* minimize = */ false);

That generated unified-memory-report-<aLabel>-<pid>.json.gz in fennec's app_tmpdir/memory-reports - great!

BUT, the file was empty - 0 length. Hmm.

Comment 3

[Geoff Brown [:gbrown]]

I have better luck with dumpMemoryReportsToNamedFile - not sure why.

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&selectedJob=213270180&revision=742acb8f65df007d0914025e6ce9fe59a7e8fc91

Comment 4

[Geoff Brown [:gbrown]]

Attachment: save memory dumps as artifacts in test_awsy_lite

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&searchStr=android&selectedJob=213394183&revision=d6fe33678c6d21babfe328e48b454a76e4b5789c

demonstrates memory dump artifacts like

https://queue.taskcluster.net/v1/task/A2cv1UneTEuY8Jip2Sr0lA/runs/0/artifacts/public/test_info//fresh-start.json.gz

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 9027037 [details] [diff] [review]
save memory dumps as artifacts in test_awsy_lite

Review of attachment 9027037 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/tests/browser/chrome/test_awsy_lite.html
@@ +39,4 @@
>    SimpleTest.requestLongerTimeout(3); // several long waits and GCs make for a long-running test
>    SimpleTest.requestCompleteLog(); // so that "PERFHERDER_DATA" can be scraped from the log
>  
> +  function checkpoint(aName, aSimpleName) {

It feels like it would be better to generate the simple name from aName, by filtering for [a-zA-Z0-9 ] and then replacing " " with "-".

Comment 6

[Mike Hommey [:glandium]]

(In reply to Geoff Brown [:gbrown] from comment #1)
> On the host, environment variable MOZ_UPLOAD_DIR provides a magic location
> for artifacts. So if runtestsremote.py ran 
> 
>   self.device.pull(remote_dir, os.environ['MOZ_UPLOAD_DIR'])

That's not part of your patch, though.

Comment 7

[Geoff Brown [:gbrown]]

(In reply to Mike Hommey [:glandium] from comment #6)
> (In reply to Geoff Brown [:gbrown] from comment #1)
> > On the host, environment variable MOZ_UPLOAD_DIR provides a magic location
> > for artifacts. So if runtestsremote.py ran 
> > 
> >   self.device.pull(remote_dir, os.environ['MOZ_UPLOAD_DIR'])
> 
> That's not part of your patch, though.

Sorry, should have explained that. The harness already pulls from self.remoteMozLog to MOZ_UPLOAD_DIR. This patch leverages that by writing the memory dumps to self.remoteMozLog.

Comment 8

[Geoff Brown [:gbrown]]

Attachment: save memory dumps as artifacts in test_awsy_lite

Now using regex replacement to derive filenames from labels.

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&selectedJob=213506250&revision=0f38ea45e82b2612a9a25961733632d146753b14

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/510f4bccd603
Store memory dump artifacts in awsy-lite; r=glandium

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/510f4bccd603