Closed
Bug 1483503
Opened 6 years ago
Closed 6 years ago
Stop setting color: MenuText on menu, menuitem, and menucaption elements
Categories
(Toolkit :: Themes, enhancement, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
2.57 KB,
patch
|
stefanh
:
review+
|
Details | Diff | Splinter Review |
popup.css already sets this color on menupopups, or, in the case of Mac, should do so.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9000197 -
Flags: review?(stefanh)
|
||
Comment 2•6 years ago
|
||
What about menu labels on non-linux?
|
|
Assignee | |
Comment 3•6 years ago
|
||
You mean menubar children on Windows? They inherit the color from the toolbar or window since they don't have a distinct background.
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9000197 [details] [diff] [review] patch (In reply to Dão Gottwald [::dao] from comment #3) > You mean menubar children on Windows? They inherit the color from the > toolbar or window since they don't have a distinct background. Ah, OK.
Attachment #9000197 -
Flags: review?(stefanh) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d367ce1c35db Stop setting color: MenuText on menu, menuitem, and menucaption elements. r=stefanh
Keywords: checkin-needed
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d367ce1c35db
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•