Stop setting color: MenuText on menu, menuitem, and menucaption elements

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

10 months ago
popup.css already sets this color on menupopups, or, in the case of Mac, should do so.
Assignee

Comment 1

10 months ago
Posted patch patchSplinter Review
Attachment #9000197 - Flags: review?(stefanh)

Comment 2

10 months ago
What about menu labels on non-linux?
Assignee

Comment 3

10 months ago
You mean menubar children on Windows? They inherit the color from the toolbar or window since they don't have a distinct background.

Comment 4

10 months ago
Comment on attachment 9000197 [details] [diff] [review]
patch

(In reply to Dão Gottwald [::dao] from comment #3)
> You mean menubar children on Windows? They inherit the color from the
> toolbar or window since they don't have a distinct background.

Ah, OK.
Attachment #9000197 - Flags: review?(stefanh) → review+
Assignee

Updated

10 months ago
Keywords: checkin-needed

Comment 5

10 months ago
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d367ce1c35db
Stop setting color: MenuText on menu, menuitem, and menucaption elements. r=stefanh
Keywords: checkin-needed

Comment 6

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d367ce1c35db
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.