Closed Bug 1483511 Opened 6 years ago Closed 6 years ago

--disable-webrtc fails to build in dom/media/gtest/ ('MediaEngineWebRTC.h' file not found)

Categories

(Core :: WebRTC, defect, P3)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: dminor)

References

Details

Attachments

(1 file)

STR
1. add "ac_add_options --disable-webrtc" to your .mozconfig file
2. ./mach build

ACTUAL RESULT
0:02.87 In file included from dom/media/gtest/Unified_cpp_dom_media_gtest0.cpp:29:
 0:02.87 dom/media/gtest/TestAudioDeviceEnumerator.cpp:12:10: fatal error: 'MediaEngineWebRTC.h' file not found
 0:02.87 #include "MediaEngineWebRTC.h"
 0:02.87          ^~~~~~~~~~~~~~~~~~~~~


Linux trunk debug build.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Comment on attachment 9001251 [details]
Bug 1483511 - Only build TestAudioDeviceEnumerator.cpp if webrtc is enabled

David Major [:dmajor] has approved the revision.
Attachment #9001251 - Flags: review+
Priority: -- → P3
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30befe133f23
Only build TestAudioDeviceEnumerator.cpp if webrtc is enabled r=dmajor,firefox-build-system-reviewers
https://hg.mozilla.org/mozilla-central/rev/30befe133f23
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: