1483528 - Don't generate super long lines in the generated file structs.rs

Status: RESOLVED WONTFIX

(Webtools Graveyard :: DXR, enhancement, P3)

Description

[Jonathan Watt [:jwatt]]

There are some really long lines in the generated file structs.rs which makes it hard to read and understand. It would be helpful if we could have the generator insert line breaks to stop this from happening, or even better, run rustfmt on the file.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

If you have rustfmt installed it should be formatted automatically, is that not happening?

Comment 2

[Jonathan Watt [:jwatt]]

I encountered this while using DXR. I see that searchfox doesn't have this problem, so I guess DXR needs to be fixed up?

Erik, any chance of that happening?

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Maybe the DXR build machine doesn't have rustfmt installed.

Comment 4

[Erik Rose [:erik][:erikrose]]

Nobody is maintaining DXR at the moment; sorry to say, it's in organizational limbo until somebody decides to resource it. :-( The rust analysis bits need especial help, as they're a naive implementation that tends to soak up all the memory on the build box.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

DXR is no longer available. Searchfox is now replacing it.
See meta bug 1669906 & https://groups.google.com/g/mozilla.dev.platform/c/jDRjrq3l-CY for more details.