1483539 - Log a success message in the treeherder formatter

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Looking at logs on treeherder, it seems that something (not codespell) fails, but some sort of error-ignoring means the task looks like success: 


[vcs 2018-08-15T13:18:25.878Z] 248147 files updated, 0 files merged, 0 files removed, 0 files unresolved
[vcs 2018-08-15T13:18:26.157Z] updated to 4d191bd81bbea9db56246856e9b09b11e2a6b4be
[vcs 2018-08-15T13:18:26.162Z] PERFHERDER_DATA: {"framework": {"name": "vcs"}, "suites": [{"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "clone", "shouldAlert": false, "subtests": [], "value": 130.92856693267822}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "update", "shouldAlert": false, "subtests": [], "value": 75.19516205787659}, {"extraOptions": ["m3.xlarge"], "lowerIsBetter": true, "name": "overall", "shouldAlert": false, "subtests": [], "value": 206.83580207824707}]}
[vcs 2018-08-15T13:18:26.472Z] TinderboxPrint:<a href=https://hg.mozilla.org/integration/mozilla-inbound/rev/4d191bd81bbea9db56246856e9b09b11e2a6b4be title='Built from mozilla-inbound revision 4d191bd81bbea9db56246856e9b09b11e2a6b4be'>4d191bd81bbea9db56246856e9b09b11e2a6b4be</a>
[task 2018-08-15T13:18:26.472Z] executing ['bash', '-cx', 'cd /builds/worker/checkouts/gecko && ./mach lint -l codespell -f treeherder']
[task 2018-08-15T13:18:26.486Z] + cd /builds/worker/checkouts/gecko
[task 2018-08-15T13:18:26.486Z] + ./mach lint -l codespell -f treeherder
[task 2018-08-15T13:18:27.206Z] New python executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python2.7
[task 2018-08-15T13:18:27.206Z] Also creating executable in /builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python
[task 2018-08-15T13:18:28.826Z] Installing setuptools, pip, wheel...done.
[task 2018-08-15T13:18:29.855Z] running build_ext
[task 2018-08-15T13:18:29.856Z] building 'psutil._psutil_linux' extension
[task 2018-08-15T13:18:29.856Z] creating build
[task 2018-08-15T13:18:29.856Z] creating build/temp.linux-x86_64-2.7
[task 2018-08-15T13:18:29.856Z] creating build/temp.linux-x86_64-2.7/psutil
[task 2018-08-15T13:18:29.856Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2018-08-15T13:18:29.856Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2018-08-15T13:18:29.856Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o
[task 2018-08-15T13:18:29.856Z] creating build/lib.linux-x86_64-2.7
[task 2018-08-15T13:18:29.856Z] creating build/lib.linux-x86_64-2.7/psutil
[task 2018-08-15T13:18:29.856Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so
[task 2018-08-15T13:18:29.856Z] building 'psutil._psutil_posix' extension
[task 2018-08-15T13:18:29.856Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2018-08-15T13:18:29.856Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2018-08-15T13:18:29.856Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2018-08-15T13:18:29.856Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2018-08-15T13:18:29.856Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2018-08-15T13:18:29.856Z] 
[task 2018-08-15T13:18:29.856Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[taskcluster 2018-08-15 13:18:32.432Z] === Task Finished ===
[taskcluster 2018-08-15 13:18:32.432Z] Successful task run with exit code: 0 completed in 242.234 seconds


The same seems to be true of any random codespell job I check [1]. 

[1] https://taskcluster-artifacts.net/U06rgcvCSaaUgicAthgxDg/0/public/logs/live_backing.log

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: bug 1483539 - test if the typo chekc is failing or not r?mgaudet

Comment 2

[Andrew Halberstadt [:ahal]]

While certainly confusing, that isn't actually an error (it'll happen anytime you clobber your objdir and re-create the virtualenv. Then when running |mach lint -f treeherder|, success doesn't print any output.

So I *think* things are likely working as expected here, but let's see if Sylvestre's test supports that theory :)

Comment 3

[Andrew Halberstadt [:ahal]]

Also, we could log "No problems found" or something similar in the treeherder formatter if there weren't any errors.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

So, it works https://phabricator.services.mozilla.com/D3411#72294 but I agree it is confusing.

This is because you have to whitelist the directory you are touching.
Add your directory here:
https://dxr.mozilla.org/mozilla-central/source/tools/lint/codespell.yml

Comment 5

[Andrew Halberstadt [:ahal]]

Let's log a success message in CI when everything passes, maybe something like:
"No lint issues found"

Comment 6

[Sylvestre Ledru [:Sylvestre]]

I found an (unrelated) bug testing that: https://github.com/mozilla/release-services/issues/1384 :)

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Andrew, maybe it is time to force the "-n" (even if we don't publish the error(s) :)
(I know I am stubborn ;)

Comment 8

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1483539 - [mozlint] Log a success message from the treeherder formatter when all lints succeed, r=Sylvestre

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 9001247 [details]
Bug 1483539 - [mozlint] Log a success message from the treeherder formatter when all lints succeed, r=Sylvestre

Sylvestre Ledru [:sylvestre] has approved the revision.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e046ec0ce93d
[mozlint] Log a success message from the treeherder formatter when all lints succeed, r=sylvestre

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e046ec0ce93d